Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC0003/LC0005 Do not raise diagnostic when symbol is missing #631

Merged
merged 1 commit into from
May 25, 2024
Merged

LC0003/LC0005 Do not raise diagnostic when symbol is missing #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Design/Rule0003DoNotUseObjectIDsInVariablesOrProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ private void CheckForObjectIDsInVariablesOrProperties(SyntaxNodeAnalysisContext
else
correctName = parameter.ParameterType.Name;

if (string.IsNullOrEmpty(correctName))
continue;

if (ctx.Node.GetLastToken().ToString().Trim('"').ToUpper() != correctName.ToUpper())
ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0003DoNotUseObjectIDsInVariablesOrProperties, ctx.Node.GetLocation(), new object[] { ctx.Node.ToString().Trim('"'), correctName }));

Expand Down