Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Split button and repeater scope for Rule0016 #615

Merged
merged 2 commits into from
May 18, 2024
Merged

Implement Split button and repeater scope for Rule0016 #615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b62847
Add logic for SplitButton with Repeater Scope
Arthurvdv May 18, 2024
41271e4
Format Document
Arthurvdv May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions Design/Rule0016CheckForMissingCaptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,44 @@ private void CheckForMissingCaptions(SymbolAnalysisContext context)
break;
}
}
else if (context.Symbol.Kind == SymbolKind.Action)
else if (context.Symbol is IActionSymbol actionSymbol)
{
switch (((IActionSymbol)context.Symbol).ActionKind)
switch (actionSymbol.ActionKind)
{
case ActionKind.Action:
if (CaptionIsMissing(context.Symbol, context))
RaiseCaptionWarning(context);
break;

case ActionKind.Group:
if (CaptionIsMissing(context.Symbol, context))
RaiseCaptionWarning(context);
break;
if (context.Symbol.GetEnumPropertyValue<ShowAsKind>(PropertyKind.ShowAs) == ShowAsKind.SplitButton)
{
// There is one specifc case where a Caption is needed on a Group where the property ShowAs is set to SplitButton
// A) The group is inside a Promoted Area
// B) Has one or more actionrefs
// C) One of the actions of the actionsrefs has Scope set to Repeater

if (((IActionSymbol)context.Symbol.ContainingSymbol).ActionKind != ActionKind.Area)
break;

if (!SemanticFacts.IsSameName(context.Symbol.ContainingSymbol.Name, "Promoted"))
break;

if (!actionSymbol.Actions.Where(a => a.ActionKind == ActionKind.ActionRef)
.Where(a => a.Target.GetEnumPropertyValueOrDefault<PageActionScopeKind>(PropertyKind.Scope) == PageActionScopeKind.Repeater)
.Any())
break;

if (CaptionIsMissing(context.Symbol, context))
RaiseCaptionWarning(context);
break;
}
else
{
if (CaptionIsMissing(context.Symbol, context))
RaiseCaptionWarning(context);
break;
}
}
}
else if (context.Symbol.Kind == SymbolKind.EnumValue)
Expand Down Expand Up @@ -151,9 +176,6 @@ private bool CaptionIsMissing(ISymbol Symbol, SymbolAnalysisContext context)
return false;
}

if (Symbol.GetEnumPropertyValue<ShowAsKind>(PropertyKind.ShowAs) == ShowAsKind.SplitButton)
return false;

if (SemanticFacts.IsSameName(Symbol.MostSpecificKind, "Group") && PromotedGroupNames.Contains(Symbol.Name.ToLowerInvariant()))
return false;

Expand Down