Merge pull request #623 from StefanMaron/TryCatch

Add TryCatch to investigate InvalidCastException
StefanMaron · May 23, 2024 · ee98f89 · ee98f89
2 parents 7e1ccc3 + 422d0ae
commit ee98f89
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/Design/Rule0043SecretText.cs b/Design/Rule0043SecretText.cs
@@ -10,7 +10,7 @@ namespace BusinessCentral.LinterCop.Design
     [DiagnosticAnalyzer]
     public class Rule0043SecretText : DiagnosticAnalyzer
     {
-        public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create<DiagnosticDescriptor>(DiagnosticDescriptors.Rule0043SecretText);
+        public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create<DiagnosticDescriptor>(DiagnosticDescriptors.Rule0043SecretText, DiagnosticDescriptors.Rule0000ErrorInRule);
 
         private static readonly string authorization = "Authorization";
 
@@ -90,7 +90,14 @@ private void AnalyzeHttpObjects(OperationAnalysisContext ctx)
                     return;
             }
 
-            if (!IsAuthorizationArgument(operation.Arguments[0])) return;
+            try
+            {
+                if (!IsAuthorizationArgument(operation.Arguments[0])) return;
+            }
+            catch (InvalidCastException)
+            {
+                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0000ErrorInRule, ctx.Operation.Syntax.GetLocation(), new Object[] { "Rule0043", "InvalidCastException", "at Line 63" }));
+            }
 
             if (!IsArgumentOfTypeSecretText(operation.Arguments[1]))
                 ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0043SecretText, ctx.Operation.Syntax.GetLocation()));