Merge pull request #374 from StefanMaron/development

Exclude FlowFilter and specific types for LC0035
StefanMaron · Nov 27, 2023 · dd760a1 · dd760a1
2 parents b0e0bc5 + f332dc4
commit dd760a1
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/Design/Rule0035ExplicitSetAllowInCustomizations.cs b/Design/Rule0035ExplicitSetAllowInCustomizations.cs
@@ -31,6 +31,8 @@ private void AnalyzeAllowInCustomization(SymbolAnalysisContext ctx)
                                                                 .Where(x => x.GetBooleanPropertyValue(PropertyKind.Enabled) != false)
                                                                 .Where(x => x.GetProperty(PropertyKind.AllowInCustomizations) is null)
                                                                 .Where(x => x.GetProperty(PropertyKind.ObsoleteState) is null)
+                                                                .Where(x => x.FieldClass != FieldClassKind.FlowFilter)
+                                                                .Where(x => IsSupportedType(x.OriginalDefinition.GetTypeSymbol().GetNavTypeKindSafe()))
                                                                 .ToList();
             if (!tableFields.Any()) return;
 
@@ -102,5 +104,21 @@ private static IEnumerable<IApplicationObjectTypeSymbol> GetRelatedPages(SymbolA
                     return null;
             }
         }
+
+        private static bool IsSupportedType(NavTypeKind navTypeKind)
+        {
+            switch (navTypeKind)
+            {
+                case NavTypeKind.Blob:
+                case NavTypeKind.Media:
+                case NavTypeKind.MediaSet:
+                case NavTypeKind.RecordId:
+                case NavTypeKind.TableFilter:
+                    return false;
+
+                default:
+                    return true;
+            }
+        }
     }
 }