Implement QuoteIdentifierIfNeeded

StefanMaron · May 26, 2024 · a4963c8 · a4963c8
1 parent eb5d697
commit a4963c8
Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/Design/Rule0005VariableCasingShouldNotDifferFromDeclaration.cs b/Design/Rule0005VariableCasingShouldNotDifferFromDeclaration.cs
@@ -208,7 +208,7 @@ private void AnalyzeIdentifierName(SyntaxNodeAnalysisContext ctx)
             string identifierName = StringExtensions.UnquoteIdentifier(node.Identifier.ValueText);
 
             if (!identifierName.AsSpan().Equals(fieldSymbol.Name.AsSpan(), StringComparison.Ordinal))
-                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0005VariableCasingShouldNotDifferFromDeclaration, node.GetLocation(), new object[] { StringExtensions.QuoteIdentifierIfNeeded(fieldSymbol.Name), "" }));
+                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0005VariableCasingShouldNotDifferFromDeclaration, node.GetLocation(), new object[] { fieldSymbol.Name.QuoteIdentifierIfNeeded(), "" }));
         }
 
         private void AnalyzeQualifiedName(SyntaxNodeAnalysisContext ctx)
@@ -223,7 +223,7 @@ private void AnalyzeQualifiedName(SyntaxNodeAnalysisContext ctx)
             string identifierName = StringExtensions.UnquoteIdentifier(node.Right.Identifier.ValueText);
 
             if (!identifierName.AsSpan().Equals(fieldSymbol.Name.AsSpan(), StringComparison.Ordinal))
-                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0005VariableCasingShouldNotDifferFromDeclaration, node.Right.GetLocation(), new object[] { StringExtensions.QuoteIdentifierIfNeeded(fieldSymbol.Name), "" }));
+                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0005VariableCasingShouldNotDifferFromDeclaration, node.Right.GetLocation(), new object[] { fieldSymbol.Name.QuoteIdentifierIfNeeded(), "" }));
         }
 
         private void AnalyzeQualifiedNameWithoutNamespace(SyntaxNodeAnalysisContext ctx)
@@ -255,7 +255,7 @@ private void AnalyzeQualifiedNameWithoutNamespace(SyntaxNodeAnalysisContext ctx)
             string identifierName = StringExtensions.UnquoteIdentifier(identifier.ValueText);
 
             if (!identifierName.AsSpan().Equals(objectTypeSymbol.Name.AsSpan(), StringComparison.Ordinal))
-                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0005VariableCasingShouldNotDifferFromDeclaration, identifierNameSyntax.GetLocation(), new object[] { StringExtensions.QuoteIdentifierIfNeeded(objectTypeSymbol.Name), "" }));
+                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0005VariableCasingShouldNotDifferFromDeclaration, identifierNameSyntax.GetLocation(), new object[] { objectTypeSymbol.Name.QuoteIdentifierIfNeeded(), "" }));
         }
 
         private void CheckForBuiltInTypeCasingMismatch(SymbolAnalysisContext ctx)

diff --git a/Design/Rule0013CheckForNotBlankOnSingleFieldPrimaryKeys.cs b/Design/Rule0013CheckForNotBlankOnSingleFieldPrimaryKeys.cs
@@ -1,6 +1,7 @@
 using BusinessCentral.LinterCop.AnalysisContextExtension;
 using Microsoft.Dynamics.Nav.CodeAnalysis;
 using Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics;
+using Microsoft.Dynamics.Nav.CodeAnalysis.Utilities;
 using System.Collections.Immutable;
 
 namespace BusinessCentral.LinterCop.Design
@@ -46,7 +47,7 @@ private static bool TableContainsNoSeries(ITableTypeSymbol table)
             {
                 var property = field.GetProperty(PropertyKind.TableRelation);
                 if (property != null)
-                    return field.GetProperty(PropertyKind.TableRelation).ValueText.StartsWith("\"No. Series\"");
+                    return field.GetProperty(PropertyKind.TableRelation).ValueText.UnquoteIdentifier().StartsWith("No. Series");
                 return false;
             });
         }

diff --git a/Design/Rule0044AnalyzeTransferField.cs b/Design/Rule0044AnalyzeTransferField.cs
@@ -184,7 +184,7 @@ private void ReportFieldDiagnostics(SyntaxNodeAnalysisContext ctx, Table table,
             {
                 TableSyntax tableSyntax = (TableSyntax)node;
 
-                return tableSyntax.Name.Identifier.ToString().Replace("\"", "");
+                return GetIdentifierName(tableSyntax.Name);
             }
 
             if (nodeType == typeof(TableExtensionSyntax))
@@ -242,7 +242,7 @@ private void ReportFieldDiagnostics(SyntaxNodeAnalysisContext ctx, Table table,
 
             IdentifierNameSyntax identifierNameSyntax = (IdentifierNameSyntax)identifier;
 
-            return identifierNameSyntax.ToString().Replace("\"", "");
+            return identifierNameSyntax.Identifier.ValueText.UnquoteIdentifier();
         }
 
         private Tuple<string, string>? GetInvokingRecordNames(InvocationExpressionSyntax invocationExpression)

diff --git a/Design/Rule0052and0053InternalProceduresNotReferenced.cs b/Design/Rule0052and0053InternalProceduresNotReferenced.cs
@@ -200,7 +200,7 @@ public void ReportUnchangedReferencePassedParameters(Action<Diagnostic> action)
                     IMethodSymbol methodSymbol = unusedInternalMethod.Key;
                     IApplicationObjectTypeSymbol objectSymbol = methodSymbol.GetContainingApplicationObjectTypeSymbol();
 
-                    Diagnostic diagnostic = Diagnostic.Create(DiagnosticDescriptors.Rule0052InternalProceduresNotReferencedAnalyzerDescriptor, methodSymbol.OriginalDefinition.GetLocation(), methodSymbol.DeclaredAccessibility.ToString().ToLowerInvariant(), StringExtensions.QuoteIdentifierIfNeeded(methodSymbol.Name), objectSymbol.NavTypeKind, StringExtensions.QuoteIdentifierIfNeeded(objectSymbol.Name), objectSymbol.DeclaredAccessibility);
+                    Diagnostic diagnostic = Diagnostic.Create(DiagnosticDescriptors.Rule0052InternalProceduresNotReferencedAnalyzerDescriptor, methodSymbol.OriginalDefinition.GetLocation(), methodSymbol.DeclaredAccessibility.ToString().ToLowerInvariant(), methodSymbol.Name.QuoteIdentifierIfNeeded(), objectSymbol.NavTypeKind, objectSymbol.Name.QuoteIdentifierIfNeeded(), objectSymbol.DeclaredAccessibility);
                     action(diagnostic);
                 }
             }
@@ -214,7 +214,7 @@ public void ReportInternalMethodOnlyReferencedInCurrentObject(Action<Diagnostic>
                     IMethodSymbol methodSymbol = internalMethodPair.Key;
                     IApplicationObjectTypeSymbol objectSymbol = methodSymbol.GetContainingApplicationObjectTypeSymbol();
 
-                    Diagnostic diagnostic = Diagnostic.Create(DiagnosticDescriptors.Rule0053InternalProcedureOnlyUsedInCurrentObjectAnalyzerDescriptor, methodSymbol.OriginalDefinition.GetLocation(), methodSymbol.DeclaredAccessibility.ToString().ToLowerInvariant(), StringExtensions.QuoteIdentifierIfNeeded(methodSymbol.Name), objectSymbol.NavTypeKind, StringExtensions.QuoteIdentifierIfNeeded(objectSymbol.Name), objectSymbol.DeclaredAccessibility);
+                    Diagnostic diagnostic = Diagnostic.Create(DiagnosticDescriptors.Rule0053InternalProcedureOnlyUsedInCurrentObjectAnalyzerDescriptor, methodSymbol.OriginalDefinition.GetLocation(), methodSymbol.DeclaredAccessibility.ToString().ToLowerInvariant(), methodSymbol.Name.QuoteIdentifierIfNeeded(), objectSymbol.NavTypeKind, objectSymbol.Name.QuoteIdentifierIfNeeded(), objectSymbol.DeclaredAccessibility);
                     action(diagnostic);
                 }
             }