Merge pull request #427 from StefanMaron/development

Resolve false positives on rule0004 (workspaces)
StefanMaron · Dec 13, 2023 · 561b7fb · 561b7fb
2 parents c8e8f2b + 32d8997
commit 561b7fb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/Design/Rule0004LookupPageIdAndDrillDownPageId.cs b/Design/Rule0004LookupPageIdAndDrillDownPageId.cs
@@ -10,14 +10,15 @@ public class Rule0004LookupPageIdAndDrillDownPageId : DiagnosticAnalyzer
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create<DiagnosticDescriptor>(DiagnosticDescriptors.Rule0004LookupPageIdAndDrillDownPageId);
 
         public override void Initialize(AnalysisContext context)
-            => context.RegisterSymbolAction(new Action<SymbolAnalysisContext>(this.CheckForLookupPageIdAndDrilldownPageId), SymbolKind.Page);
+            => context.RegisterSymbolAction(new Action<SymbolAnalysisContext>(this.CheckForLookupPageIdAndDrillDownPageId), SymbolKind.Page);
 
-        private void CheckForLookupPageIdAndDrilldownPageId(SymbolAnalysisContext context)
+        private void CheckForLookupPageIdAndDrillDownPageId(SymbolAnalysisContext context)
         {
             if (context.Symbol.IsObsoletePending || context.Symbol.IsObsoleteRemoved) return;
             IPageTypeSymbol pageTypeSymbol = (IPageTypeSymbol)context.Symbol;
-            if (pageTypeSymbol.PageType == PageTypeKind.List && pageTypeSymbol.RelatedTable != null)
-                CheckTable(pageTypeSymbol.RelatedTable, ref context);
+            if (pageTypeSymbol.PageType != PageTypeKind.List || pageTypeSymbol.RelatedTable == null) return;
+            if (pageTypeSymbol.RelatedTable.ContainingModule != context.Symbol.ContainingModule) return;
+            CheckTable(pageTypeSymbol.RelatedTable, ref context);
         }
 
         private void CheckTable(ITableTypeSymbol table, ref SymbolAnalysisContext context)