Verify %1 on filter expression

StefanMaron · Jan 8, 2024 · 3c411ac · 3c411ac
1 parent ea9ffc5
commit 3c411ac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Design/Rule0050SetFilterOperatorCharInFilterExpression.cs b/Design/Rule0050SetFilterOperatorCharInFilterExpression.cs
@@ -2,6 +2,7 @@
 using Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics;
 using Microsoft.Dynamics.Nav.CodeAnalysis.Symbols;
 using System.Collections.Immutable;
+using System.Text.RegularExpressions;
 
 namespace BusinessCentral.LinterCop.Design
 {
@@ -39,6 +40,11 @@ private void CheckParameter(IOperation operand, ref IInvocationExpression operat
                 return;
 
             string parameterString = operand.Syntax.ToFullString();
+
+            string pattern = @"%\d+"; // Only when a %1 is used in the filter expression the unsupported operators are threaded as a literal character
+            Regex regex = new Regex(pattern);
+            if (!regex.IsMatch(parameterString)) return;
+
             foreach (char unsupportedOperator in unsupportedOperators)
             {
                 ctx.CancellationToken.ThrowIfCancellationRequested();

diff --git a/LinterCopAnalyzers.resx b/LinterCopAnalyzers.resx
@@ -556,12 +556,12 @@
     <value>SourceTable property not defined on {0} '{1}'.</value>
   </data>
   <data name="Rule0050SetFilterOperatorCharInFilterExpressionTitle" xml:space="preserve">
-    <value>Operator '{0}' found in filter expression, currently treated as a literal character. Implement StrSubstNo() to apply '{0}' as operator.</value>
+    <value>Operator '{0}' found in filter expression, currently treated as a literal character. Implement StrSubstNo() to apply as operator.</value>
   </data>
   <data name="Rule0050SetFilterOperatorCharInFilterExpressionFormat" xml:space="preserve">
-    <value>Operator '{0}' found in filter expression, currently treated as a literal character. Implement StrSubstNo() to apply '{0}' as operator.</value>
+    <value>Operator '{0}' found in filter expression, currently treated as a literal character. Implement StrSubstNo() to apply as operator.</value>
   </data>
   <data name="Rule0050SetFilterOperatorCharInFilterExpressionDescription" xml:space="preserve">
-    <value>Operator '{0}' found in filter expression, currently treated as a literal character. Implement StrSubstNo() to apply '{0}' as operator.</value>
+    <value>Operator '{0}' found in filter expression, currently treated as a literal character. Implement StrSubstNo() to apply as operator.</value>
   </data>
 </root>