Add HowlGlobal Volume (With example) #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
requested changes
Jun 15, 2021
There was a problem hiding this comment.
The Volume(...) method should also be added to the https://github.com/StefH/Howler.Blazor/blob/master/src/Howler.Blazor/Components/IHowl.cs to enable setting the volume for a specific sound.
StefH
requested changes
Jun 15, 2021
| @@ -47,12 +47,25 @@ | |||
| <td><button class="btn btn-primary oi oi-arrow-bottom" @onclick="SpeedDown"></button></td> | |||
| <td>Speed Down</td> | |||
| </tr> | |||
| <tr> | |||
There was a problem hiding this comment.
Can you please also update all 3 example projects?
| @@ -245,4 +261,24 @@ | |||
| await Howl.Pause(id); | |||
| } | |||
| } | |||
| private async Task VolumeUp() | |||
| private async Task VolumeUp() | ||
| { | ||
| Volume += 0.1; | ||
| // await HowlGlobal.Volume(Volume); |
There was a problem hiding this comment.
maybe keep the await HowlGlobal.Volume(Volume); and put the foreach loop in comment?
| @@ -105,6 +105,11 @@ public ValueTask<bool> IsPlaying(int soundId) | |||
| return _runtime.InvokeAsync<bool>("howl.getIsPlaying", soundId); | |||
| } | |||
|
|
|||
| public ValueTask<double> Volume(double volume, int soundId) | |||
| @@ -48,6 +48,8 @@ public interface IHowl : IHowlEvents | |||
| ValueTask<TimeSpan> GetTotalTime(int soundId); | |||
|
|
|||
| ValueTask<bool> IsPlaying(int soundId); | |||
| ValueTask<double> Volume(double volume, int soundId); | |||
| @@ -48,6 +48,8 @@ public interface IHowl : IHowlEvents | |||
| ValueTask<TimeSpan> GetTotalTime(int soundId); | |||
|
|
|||
| ValueTask<bool> IsPlaying(int soundId); | |||
| ValueTask<double> Volume(double volume, int soundId); | |||
|
|
|||
| @@ -17,5 +17,6 @@ public interface IHowlGlobal | |||
| ValueTask<string[]> GetCodecs(); | |||
|
|
|||
| ValueTask<bool> IsCodecSupported(string? extension); | |||
| ValueTask Volume(double volume); | |||
| return howl.volume(volume, id); | ||
| } | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
don't return 0 here, that is not needed
|
@grierson |
|
Hello @grierson ; did you have time to take a look at my code review comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.