Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh connector samples (on main branch) #279

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Refresh connector samples (on main branch) #279

merged 4 commits into from
Jan 20, 2023

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Jan 18, 2023 •
edited
Loading

Updated connector samples, based on default MvcWebApplication project template, targeting .NET 7 .NET 6:

  • CosmosDb
  • MongoDb
  • MySql
  • MySqlEFCore
  • OAuth
  • PostgreSql
  • PostgreSqlEFCore
  • RabbitMQ
  • Redis
  • SqlServerEFCore

Review notes:

  • Please ignore all changes below wwwroot. I just copied it from the default template, and there were/are no Steeltoe-specific customizations, as far as I'm aware.
  • Due to the large amount of changes, GitHub is unable to properly match up old/new file names. Therefore I recommend to diff locally using a filesystem-based tool.
  • The integration tests for CosmosDb, MongoDb, PostgreSql, PostgreSqlEFCore, and SqlServerEFCore fail due to configure firewall to allow access to test databases #273. Because of time constraints, we've decided to address that later. Despite that, I've manually tested all of them, both locally and on CloudFoundry.

@bart-vmware
Updated connector samples, based on default MvcWebApplication project…
7c0a015 
… template, targeting .NET 7:

- CosmosDb
- MongoDb
- MySql
- MySqlEFCore
- OAuth
- PostgreSql
- PostgreSqlEFCore
- RabbitMQ
- Redis
- SqlServerEFCore
@bart-vmware bart-vmware marked this pull request as ready for review January 18, 2023 14:47
@TimHess
Copy link
Member

TimHess commented Jan 18, 2023

This generally looks good to me. As discussed in the team call earlier today, if the samples in main can continue to target .NET 6 I think that is preferred for now. If that change introduces significant rework, then it would be OK to target .NET 7.

@bart-vmware
Copy link
Member Author

bart-vmware commented Jan 19, 2023 •
edited
Loading

This generally looks good to me. As discussed in the team call earlier today, if the samples in main can continue to target .NET 6 I think that is preferred for now. If that change introduces significant rework, then it would be OK to target .NET 7.

Locally they all work on .NET 6, except for the SQL Server sample. That's because it requires SteeltoeOSS/Steeltoe#1094, but the pre-release version number on SteeltoeDev feed is incorrect, so it picks the stable v3.2.2 instead.

Update: The SQL Server issue was resolved by SteeltoeOSS/Steeltoe#1096.

TimHess
TimHess approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware merged commit 71a5686 into main Jan 20, 2023
@bart-vmware bart-vmware deleted the refresh-connector-samples-main branch January 20, 2023 14:48
@bart-vmware bart-vmware mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess approved these changes

@dtillman dtillman Awaiting requested review from dtillman

@ccheetham ccheetham Awaiting requested review from ccheetham

@hananiel hananiel Awaiting requested review from hananiel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bart-vmware @TimHess @hananiel