-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spring Boot Admin pipeline, update SBA, Eureka and Config Server deps #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: move from HTTPIE to CURL and append "-pr" to image name during PR builds
TimHess
force-pushed
the
spring-boot-admin
branch
from
September 25, 2024 19:06
36bdcb3
to
95e050a
Compare
TimHess
changed the title
Revisit/Update Spring Boot Admin Image
Add Spring Boot Admin pipeline, update SBA, Eureka and Config Server deps
Sep 25, 2024
TimHess
force-pushed
the
spring-boot-admin
branch
2 times, most recently
from
September 25, 2024 19:43
e4c3163
to
cfdefad
Compare
TimHess
force-pushed
the
spring-boot-admin
branch
from
September 25, 2024 19:52
cfdefad
to
fd082e0
Compare
bart-vmware
reviewed
Sep 26, 2024
TimHess
force-pushed
the
spring-boot-admin
branch
6 times, most recently
from
September 26, 2024 20:02
e0e0845
to
cdc2ef7
Compare
bart-vmware
reviewed
Sep 27, 2024
bart-vmware
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One textual update is still missing.
…-DirectoryName addition, update readme files, use alpine for config server running image
TimHess
force-pushed
the
spring-boot-admin
branch
from
September 27, 2024 14:10
cdc2ef7
to
495f6c4
Compare
bart-vmware
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build SBA server via start.spring.io the same way our Eureka & Config Server images are built.
Switch to cURL and update all to the latest versions for all 3 images built from start.spring.io.
Also use different image names during PR builds to avoid unexpected overwrites in the image repository
Closes #14