Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete images, update config server & eureka and add pipelines #32

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Feb 22, 2024

At least half of #14 (Spring Boot Admin and UAA should be out of scope for this PR),
resolves #13

PR builds now push images to steeltoe.azurecr.io using the same tags they will go to dockerhub with so we can easily test

For example:

docker run -p 8761:8761 steeltoe.azurecr.io/eureka-server:4.1.0
docker run -p 8888:8888 steeltoe.azurecr.io/config-server:4.1.0

@TimHess TimHess self-assigned this Feb 22, 2024
@TimHess TimHess force-pushed the updates branch 2 times, most recently from db2e91d to b927d0d Compare February 22, 2024 21:03
@TimHess
Copy link
Member Author

TimHess commented Feb 23, 2024

I thought this was ready, but the config server image that deployed doesn't work, and I think we can make the image versioning work off of a single source of truth (right now its files in /metadata and also version.patch)

Images work, versioning now based off contents off metadata/IMAGE_VERSION

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
.github/workflows/build_config_server.yaml Outdated Show resolved Hide resolved
.github/workflows/build_eureka_server.yaml Outdated Show resolved Hide resolved
build.ps1 Outdated Show resolved Hide resolved
@TimHess TimHess marked this pull request as ready for review February 26, 2024 17:15
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker link is missing.

README.adoc Show resolved Hide resolved
README.adoc Show resolved Hide resolved
@TimHess TimHess merged commit e48ddae into main Feb 27, 2024
3 checks passed
@TimHess TimHess deleted the updates branch February 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add current eureka-server image
2 participants