Skip to content

Add Deadlock protos #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

Add Deadlock protos #1539

merged 1 commit into from
May 17, 2025

Conversation

psychonic
Copy link
Member

  • Added Deadlock GC protos to protos.csv
  • Generated code for Deadlock GC protos
  • Added NHA specialization for Deadlock GC

@xPaw
Copy link
Member

xPaw commented May 10, 2025

See also #1426, main problem being the library is not trimmable.

@psychonic
Copy link
Member Author

That's a fair point. I didn't realize that other PR existed. (It also includes many protos that don't involve Steam traffic).

I would argue that there's no harm in including more until that potential future point in time when all are dropped.

@psychonic
Copy link
Member Author

psychonic commented May 10, 2025

Disregard that latest commit updating the steamlanguage files. I meant to include it in a separate branch. Removing shortly...

@xPaw
Copy link
Member

xPaw commented May 10, 2025

I won't block this. I assume we can't really use shared generic Steam protos because they can be out of sync between games (is that a problem)?

@psychonic psychonic force-pushed the psy/deadlock-protos branch from 43f321a to c043798 Compare May 10, 2025 17:45
@psychonic
Copy link
Member Author

I won't block this. I assume we can't really use shared generic Steam protos because they can be out of sync between games?

I'm not certain, but I think those base ones (steammessages_*) may be able to be shared. While they differ between games, I believe it's only due to them being synced from the steam code to the game's gcsdk at different times. In at least most cases, I would think the newer ones are backward compatible with old.

@voided may remember why that wasn't originally unified

@psychonic
Copy link
Member Author

Oh, I think I remember now. At the network level, they're compatible. But the game-specific proto classes reference the steam ones in some cases, and there can be compatibility issues there when using a different version, or if the generated class path isn't what it's expecting (although some hackery may be able to deal with the latter)

@psychonic psychonic merged commit 157eb2b into master May 17, 2025
17 checks passed
@psychonic psychonic deleted the psy/deadlock-protos branch May 17, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants