Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR Pipeline and Update github actions versions #670

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Fix PR Pipeline and Update github actions versions #670

merged 9 commits into from
Jun 10, 2024

Conversation

MatthewGlenn
Copy link
Contributor

  • Updated the following actions to fix the node js deprecation warnings
    • actions/checkout@v2 -> 4.1.6
    • actions/[email protected] -> 4.0.2
      • node-version: 14.18.1 -> 22.2.0
    • actions/setup-python@v4 -> 5.1.0
    • actions/upload-artifact@v3 -> 4.3.3
  • Fix the PR Pipeline: I noticed the pull request workflow failed the Install dependencies step when the Setup Python environment step wasn't run first. So I added the python step step before dependencies are installed.
  • Not sure if it was intended, but the macOS build artifacts were not being uploaded in the pull requests workflow while the Windows and Linux versions were. I added a step to upload them.

@cbartondock
Copy link
Collaborator

Thanks! This looks good, I will merge it after I get the next release out.

@cbartondock cbartondock merged commit be02346 into SteamGridDB:master Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewGlenn @cbartondock