Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Opt-In Status W/ VAN #2524

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Update Opt-In Status W/ VAN #2524

wants to merge 22 commits into from

Conversation

engelhartrueben
Copy link
Collaborator

@engelhartrueben engelhartrueben commented Dec 5, 2024

Fixes # (issue)

Adds a feature to update opt-out status with VAN.

Description

Adds a message handler feature that relays a contact has chosen to opt out back to NGP VAN.
This feature relies on the auto-optout message-handler to mark that the individual has chosen to opt out. Additionally, manually opting someone out is supported.

Note

Please let me know if I should compress my commits.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • [ x I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben engelhartrueben added the S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed label Dec 5, 2024
@engelhartrueben engelhartrueben requested a review from mau11 December 5, 2024 17:25
Ruby Engelhart and others added 13 commits December 6, 2024 11:39
…how to update a users opt in status.

Result code id changed from 205 to 130 (Do not text result code).
Cell is checked later down the call chain, so don't need to worry here.
customFields >> custom_fields.
Test is updated to reflect these changes.
"contact" is not passed to postMessageSave (even though its passed in cacheable_queries.message).

This queries the DB for the custom fields table which include van id, and uses that to update the VAN records.
Same concept before, but building this POST request from scratch as the contact object is not always passed to postMessageSave.
…re we opt someone out after we send them a message
@engelhartrueben engelhartrueben added C-enhancement Type: enhancement A-opt out Area: Opt outs and removed S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed labels Dec 13, 2024
@engelhartrueben engelhartrueben changed the title (WIP) Update Opt-In Status W/ VAN Update Opt-In Status W/ VAN Dec 13, 2024
@engelhartrueben engelhartrueben marked this pull request as ready for review December 13, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-opt out Area: Opt outs C-enhancement Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant