-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Opt-In Status W/ VAN #2524
Open
engelhartrueben
wants to merge
22
commits into
main
Choose a base branch
from
re/VAN_auto_opt_out
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message handler sends a request to VAN to update a given record if the contact opts out via our auto-optout feature.
… out by the texter. Runs similar to the proposed ngp-optout message handler. May need to add additional checks to ensure that the contact has a vanid
…how to update a users opt in status. Result code id changed from 205 to 130 (Do not text result code). Cell is checked later down the call chain, so don't need to worry here. customFields >> custom_fields. Test is updated to reflect these changes.
"contact" is not passed to postMessageSave (even though its passed in cacheable_queries.message). This queries the DB for the custom fields table which include van id, and uses that to update the VAN records.
Same concept before, but building this POST request from scratch as the contact object is not always passed to postMessageSave.
…tout message handler code
…re we opt someone out after we send them a message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Adds a feature to update opt-out status with VAN.
Description
Adds a message handler feature that relays a contact has chosen to opt out back to NGP VAN.
This feature relies on the
auto-optout
message-handler to mark that the individual has chosen to opt out. Additionally, manually opting someone out is supported.Note
Please let me know if I should compress my commits.
Checklist: