Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Hadolint to fail builds #735

Merged
merged 14 commits into from
Jan 24, 2025
Merged

Enable Hadolint to fail builds #735

merged 14 commits into from
Jan 24, 2025

Conversation

EveningStarlight
Copy link
Contributor

@EveningStarlight EveningStarlight commented Jan 22, 2025

investigates removing --no-fail from Hadolint

Part of #732

Hadolint checks had to be moved below the FROM *** as *** injection, or would else error out on the missing FROM

Fixes made for

Hadolint should be after the FROM injection,
or else it has a bunch of false errors
@EveningStarlight
Copy link
Contributor Author

Current errors to resolve

 images/base/Dockerfile:73 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root

images/remote-desktop/Dockerfile:129 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root
images/remote-desktop/Dockerfile:421 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root
images/remote-desktop/Dockerfile:444 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root

images/rstudio/Dockerfile:5 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root
images/rstudio/Dockerfile:5 DL3005 error: Do not use apt-get dist-upgrade

images/tensorflow/Dockerfile:19 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root

@EveningStarlight EveningStarlight changed the title Move hadolint in build order Enable Hadolint to fail builds Jan 23, 2025
Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple empty files with no reference were commited

images/base/force-build.txt Outdated Show resolved Hide resolved
images/remote-desktop/force-build.txt Outdated Show resolved Hide resolved
images/base/Dockerfile Show resolved Hide resolved
Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EveningStarlight EveningStarlight merged commit da85328 into master Jan 24, 2025
50 checks passed
@EveningStarlight EveningStarlight deleted the test-hadolint branch January 24, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants