Update/0.18.0

[Dominion5254]

• Update LND to 0.18.0
• Update buildService and releaseService actions
• Add missing migration
• Fix build errors

[ProofOfKeags]

Small UX note regarding ensuring that if zero-conf is enabled you must also have scid-alias enabled as well.

EDIT: Also to take full advantage of the new update I recommend adding the sweeper options into the advanced section of the config.

[Dominion5254]

If I understand correctly, exposing the sweeper config options basically allow users to potentially optimize/save on sweep fees with the tradeoff of potential loss of funds if the values are set too low. Am I understanding this correctly, or is that only a concern for sweeper.maxfeerate?

I would be somewhat hesitant to expose users that potential footgun and the resulting support load.

[ProofOfKeags]

If I understand correctly, exposing the sweeper config options basically allow users to potentially optimize/save on sweep fees with the tradeoff of potential loss of funds if the values are set too low. Am I understanding this correctly, or is that only a concern for sweeper.maxfeerate?

These values help inform the sweeper how to make decisions wrt how much it burns in chain fees in order to recover possibly contested outputs (HTLCs and Breach outputs). Unfortunately there's no "correct" value, which is precisely why we expose it. There is risk of fund loss for all values via two vectors: unclaimed outputs, and overpaying for fees.

I would be somewhat hesitant to expose users that potential footgun and the resulting support load.

This is fair. I also would like to see every user option exposed eventually. I figure the "Advanced" section of the menu should be where this stuff lives anyway. What kind of assurance are you looking for here?

[ProofOfKeags]

I think you also want to include Option<usize> values for the different fee caps