Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Do not do filter pushdown for project that contains lambda function (backport #52655) #52781

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2024

Why I'm doing:

prevent expensive array_map from being pushed down.

What I'm doing:

Optionally disable predicate pushdown for lambda expressions through the new set variable:

set disable_lambda_pushdown=true

Example:

query:
set pipeline_dop=1;
explain
WITH input AS (
  SELECT
    array_min( array_map(x -> coalesce(x, ""), CELONIS__CACHE_ARRAY_STRING__1 )) + rand() AS x
  FROM
    test.O_CUSTOM_AUFTRAG
),
input2 as (
  select length(x)+1 as a, length(x)+2 as b, length(x)+3 as c
  from input
)

SELECT * from input2
where a + b + c <10

explain:

PLAN FRAGMENT 0
 OUTPUT EXPRS:9: expr | 10: expr | 11: expr
  PARTITION: UNPARTITIONED

  RESULT SINK

  4:EXCHANGE

PLAN FRAGMENT 1
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 04
    UNPARTITIONED

  3:Project
  |  <slot 9> : 14: cast + 1
  |  <slot 10> : 14: cast + 2
  |  <slot 11> : 14: cast + 3
  |  common expressions:
  |  <slot 12> : CAST(8: expr AS VARCHAR)
  |  <slot 13> : length(12: cast)
  |  <slot 14> : CAST(13: length AS BIGINT)
  |  
  2:SELECT
  |  predicates: CAST(length(CAST(8: expr AS VARCHAR)) AS BIGINT) + 1 + CAST(length(CAST(8: expr AS VARCHAR)) AS BIGINT) + 2 + CAST(length(CAST(8: expr AS VARCHAR)) AS BIGINT) + 3 < 10
  |  
  1:Project
  |  <slot 8> : CAST(array_min(array_map(<slot 7> -> coalesce(<slot 7>, ''), 5: CELONIS__CACHE_ARRAY_STRING__1)) AS DOUBLE) + rand()
  |  
  0:OlapScanNode
     TABLE: O_CUSTOM_AUFTRAG
     PREAGGREGATION: ON
     partitions=1/1
     rollup: O_CUSTOM_AUFTRAG
     tabletRatio=3620/3620
     tabletList=17430,17432,17434,17436,17438,17440,17442,17444,17446,17448 ...
     cardinality=2
     avgRowSize=2.0

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52655 done by [Mergify](https://mergify.com). ## Why I'm doing:

prevent expensive array_map from being pushed down.

What I'm doing:

Optionally disable predicate pushdown for lambda expressions through the new set variable:

set disable_lambda_pushdown=true

Example:

query:
set pipeline_dop=1;
explain
WITH input AS (
  SELECT
    array_min( array_map(x -> coalesce(x, ""), CELONIS__CACHE_ARRAY_STRING__1 )) + rand() AS x
  FROM
    test.O_CUSTOM_AUFTRAG
),
input2 as (
  select length(x)+1 as a, length(x)+2 as b, length(x)+3 as c
  from input
)

SELECT * from input2
where a + b + c <10

explain:

PLAN FRAGMENT 0
 OUTPUT EXPRS:9: expr | 10: expr | 11: expr
  PARTITION: UNPARTITIONED

  RESULT SINK

  4:EXCHANGE

PLAN FRAGMENT 1
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 04
    UNPARTITIONED

  3:Project
  |  <slot 9> : 14: cast + 1
  |  <slot 10> : 14: cast + 2
  |  <slot 11> : 14: cast + 3
  |  common expressions:
  |  <slot 12> : CAST(8: expr AS VARCHAR)
  |  <slot 13> : length(12: cast)
  |  <slot 14> : CAST(13: length AS BIGINT)
  |  
  2:SELECT
  |  predicates: CAST(length(CAST(8: expr AS VARCHAR)) AS BIGINT) + 1 + CAST(length(CAST(8: expr AS VARCHAR)) AS BIGINT) + 2 + CAST(length(CAST(8: expr AS VARCHAR)) AS BIGINT) + 3 < 10
  |  
  1:Project
  |  <slot 8> : CAST(array_min(array_map(<slot 7> -> coalesce(<slot 7>, ''), 5: CELONIS__CACHE_ARRAY_STRING__1)) AS DOUBLE) + rand()
  |  
  0:OlapScanNode
     TABLE: O_CUSTOM_AUFTRAG
     PREAGGREGATION: ON
     partitions=1/1
     rollup: O_CUSTOM_AUFTRAG
     tabletRatio=3620/3620
     tabletList=17430,17432,17434,17436,17438,17440,17442,17444,17446,17448 ...
     cardinality=2
     avgRowSize=2.0

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Nov 11, 2024

@wanpengfei-git wanpengfei-git merged commit 751ba53 into branch-3.3 Nov 11, 2024
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-52655 branch November 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants