Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance text base mv rewrite (backport #52498) #52543

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 1, 2024

Why I'm doing:

Query cannot be rewritten by mv-texted based rewrite if mv has order by and query has order by even if the defined query are exactly the same because subquery will eliminate the order by in the subquery which cause text match failed:

MV: select user_id, time, bitmap_union(to_bitmap(tag_id)) as a from user_tags group by user_id, time order by user_id, time;

Query: select user_id, count(time) from (MV) as t group by user_id limit 3

What I'm doing:

  • Register an extra ast key if the mv's defined query has order by elements and without limit, so can be used to rewrite for the eliminated sorted-by input query.
  • Correct the materialized_view_subuqery_text_match_max_count parameter which means the real sub query match count limit.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52498 done by [Mergify](https://mergify.com). ## Why I'm doing:

Query cannot be rewritten by mv-texted based rewrite if mv has order by and query has order by even if the defined query are exactly the same because subquery will eliminate the order by in the subquery which cause text match failed:

MV: select user_id, time, bitmap_union(to_bitmap(tag_id)) as a from user_tags group by user_id, time order by user_id, time;

Query: select user_id, count(time) from (MV) as t group by user_id limit 3

What I'm doing:

  • Register an extra ast key if the mv's defined query has order by elements and without limit, so can be used to rewrite for the eliminated sorted-by input query.
  • Correct the materialized_view_subuqery_text_match_max_count parameter which means the real sub query match count limit.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Nov 1, 2024
Copy link
Contributor Author

mergify bot commented Nov 1, 2024

Cherry-pick of 6029ee2 has failed:

On branch mergify/bp/branch-3.2/pr-52498
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 6029ee28bc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/rule/TextMatchBasedRewriteRule.java
	modified:   fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTextBasedRewriteTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Nov 1, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled November 1, 2024 07:25

Pull request was closed

@LiShuMing LiShuMing reopened this Nov 4, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 4, 2024 02:11
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 6029ee2)
@LiShuMing LiShuMing force-pushed the mergify/bp/branch-3.2/pr-52498 branch from 5b2e00b to 8bc9018 Compare November 4, 2024 03:33
Copy link

sonarcloud bot commented Nov 4, 2024

@wanpengfei-git wanpengfei-git merged commit 1dd791f into branch-3.2 Nov 4, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-52498 branch November 4, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants