Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error (backport #52482) #52494

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 31, 2024

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/8775

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52482 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/8775

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…#52482)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit d44ae38)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/alter/AlterJobExecutor.java
#	test/sql/test_alter_table/R/test_alter_table_abnormal
#	test/sql/test_alter_table/T/test_alter_table_abnormal
@mergify mergify bot added the conflicts label Oct 31, 2024
Copy link
Contributor Author

mergify bot commented Oct 31, 2024

Cherry-pick of d44ae38 has failed:

On branch mergify/bp/branch-3.2/pr-52482
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit d44ae38108.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/alter/AlterJobExecutor.java
	deleted by us:   test/sql/test_alter_table/R/test_alter_table_abnormal
	deleted by us:   test/sql/test_alter_table/T/test_alter_table_abnormal

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 31, 2024 06:09
@mergify mergify bot closed this Oct 31, 2024
auto-merge was automatically disabled October 31, 2024 06:10

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 31, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@meegoo meegoo reopened this Oct 31, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 31, 2024 06:50
@meegoo meegoo disabled auto-merge October 31, 2024 18:34
@meegoo meegoo enabled auto-merge (squash) October 31, 2024 18:34
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@meegoo meegoo disabled auto-merge October 31, 2024 21:07
@meegoo meegoo merged commit bc9c235 into branch-3.2 Nov 1, 2024
27 of 29 checks passed
@meegoo meegoo deleted the mergify/bp/branch-3.2/pr-52482 branch November 1, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant