Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] support base manual compaction for cloud table #52461

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[Enhancement] support base manual compaction for cloud table #52461

merged 1 commit into from
Nov 5, 2024

Conversation

starrocks-xupeng
Copy link
Contributor

@starrocks-xupeng starrocks-xupeng commented Oct 30, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

lake table should align the behavior with native table when calling alter table xxx compact

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@starrocks-xupeng starrocks-xupeng requested a review from a team as a code owner October 30, 2024 05:57
@github-actions github-actions bot added the 3.3 label Oct 30, 2024
@wanpengfei-git wanpengfei-git requested a review from a team October 30, 2024 06:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

[BE Incremental Coverage Report]

✅ pass : 25 / 26 (96.15%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/compaction_policy.cpp 14 15 93.33% [394]
🔵 be/src/storage/lake/compaction_scheduler.cpp 1 1 100.00% []
🔵 be/src/storage/lake/primary_key_compaction_policy.h 2 2 100.00% []
🔵 be/src/storage/lake/tablet_manager.cpp 2 2 100.00% []
🔵 be/src/storage/lake/compaction_policy.h 4 4 100.00% []
🔵 be/src/storage/lake/compaction_task_context.h 2 2 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

[FE Incremental Coverage Report]

❌ fail : 10 / 18 (55.56%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/lake/compaction/CompactionScheduler.java 3 11 27.27% [212, 213, 218, 220, 221, 260, 320, 359]
🔵 com/starrocks/lake/compaction/PartitionStatisticsSnapshot.java 2 2 100.00% []
🔵 com/starrocks/lake/compaction/CompactionMgr.java 5 5 100.00% []

@andyziye andyziye merged commit 46ca655 into StarRocks:main Nov 5, 2024
51 of 54 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 5, 2024
@starrocks-xupeng @mergify
[Enhancement] support base manual compaction for cloud table (#52461)
c6a5825 
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 46ca655)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/lake/compaction/CompactionScheduler.java
@mergify mergify bot mentioned this pull request Nov 5, 2024
Closed
42 tasks
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@starrocks-xupeng @renzhimin7
[Enhancement] support base manual compaction for cloud table (StarRoc…
1c6e950 
…ks#52461)

Signed-off-by: starrocks-xupeng <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
wyb pushed a commit that referenced this pull request Nov 11, 2024
@starrocks-xupeng
[Enhancement] support base manual compaction for cloud table (backport …
97610d9 
…#52461) (#52637)

Signed-off-by: starrocks-xupeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

@wangruin wangruin wangruin approved these changes

@wyb wyb wyb approved these changes

Assignees

@starrocks-xupeng starrocks-xupeng

Labels
3.3-merged PROTO-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@starrocks-xupeng @wyb @wangruin @murphyatwork @wanpengfei-git @andyziye