Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Remove query sync mv read lock (backport #52239) #52251

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 23, 2024

Why I'm doing:

  • lock has been done in analyze phase, no need to lock again.
        // 1. For all queries, we need db lock when analyze phase
        PlannerMetaLocker plannerMetaLocker = new PlannerMetaLocker(session, stmt);
        try (var guard = session.bindScope()) {
            // Analyze
            analyzeStatement(stmt, session, plannerMetaLocker);

What I'm doing:

  • Remove query sync mv read lock

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52239 done by [Mergify](https://mergify.com). ## Why I'm doing: - lock has been done in analyze phase, no need to lock again. ``` // 1. For all queries, we need db lock when analyze phase PlannerMetaLocker plannerMetaLocker = new PlannerMetaLocker(session, stmt); try (var guard = session.bindScope()) { // Analyze analyzeStatement(stmt, session, plannerMetaLocker); ``` ## What I'm doing: - Remove query sync mv read lock

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 77ecc91)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/QueryAnalyzer.java
@mergify mergify bot added the conflicts label Oct 23, 2024
Copy link
Contributor Author

mergify bot commented Oct 23, 2024

Cherry-pick of 77ecc91 has failed:

On branch mergify/bp/branch-3.3/pr-52239
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 77ecc912fd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/QueryAnalyzer.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Oct 23, 2024
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 23, 2024 11:49
@mergify mergify bot closed this Oct 23, 2024
auto-merge was automatically disabled October 23, 2024 11:49

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 23, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@LiShuMing LiShuMing reopened this Nov 11, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 11, 2024 02:29
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Nov 11, 2024

@wanpengfei-git wanpengfei-git merged commit 8ba521e into branch-3.3 Nov 11, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-52239 branch November 11, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants