Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support iceberg incremental scan range #52248

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Oct 23, 2024

Why I'm doing:

What I'm doing:

major changes:

  • support iceberg connector scan range source
  • support incremental iceberg remote file source
  • adapt to IcebergEqualityDeleteRewriteRule
  • disable empty prune rule on iceberg
  • refactor iceberg metadata and iceberg scan node.

table with equality delete files related:
we have optimized performance by rewrite scan plan in the #51050
To adapt incremental scan range, we use the new plan.
image

For remote source scan range.

  • table without eq-delete files
    image

  • table with eq-delete files
    image

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

dirtysalt
dirtysalt previously approved these changes Oct 23, 2024
@stephen-shelby stephen-shelby changed the title [Feature] support iceberg incremental scan range [Enhancement] support iceberg incremental scan range Oct 23, 2024
Seaven
Seaven previously approved these changes Oct 24, 2024
Signed-off-by: stephen <[email protected]>
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 524 / 618 (84.79%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/iceberg/IcebergRemoteFileInfoSourceKey.java 0 14 00.00% [31, 32, 33, 40, 41, 46, 47, 49, 50, 52, 53, 56, 57, 62]
🔵 com/starrocks/connector/ConnectorMetadata.java 0 1 00.00% [349]
🔵 com/starrocks/server/MetadataMgr.java 3 7 42.86% [788, 789, 790, 793]
🔵 com/starrocks/connector/GetRemoteFilesParams.java 1 2 50.00% [61]
🔵 com/starrocks/connector/iceberg/IcebergMetadata.java 59 90 65.56% [867, 868, 869, 870, 873, 874, 875, 876, 877, 878, 880, 881, 882, 885, 886, 887, 888, 890, 891, 896, 897, 898, 899, 900, 904, 911, 912, 913, 916, 921, 984]
🔵 com/starrocks/connector/iceberg/IcebergRemoteSourceTrigger.java 39 55 70.91% [50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 61, 62, 64, 67, 68, 98]
🔵 com/starrocks/sql/optimizer/operator/physical/PhysicalUnionOperator.java 4 5 80.00% [53]
🔵 com/starrocks/connector/iceberg/IcebergMORParams.java 23 28 82.14% [72, 73, 74, 75, 84]
🔵 com/starrocks/connector/iceberg/IcebergGetRemoteFilesParams.java 11 13 84.62% [32, 36]
🔵 com/starrocks/connector/iceberg/IcebergDeleteSchema.java 12 14 85.71% [44, 47]
🔵 com/starrocks/planner/IcebergScanNode.java 52 60 86.67% [81, 82, 85, 97, 117, 162, 163, 262]
🔵 com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java 15 17 88.24% [522, 1283]
🔵 com/starrocks/connector/iceberg/IcebergConnectorScanRangeSource.java 152 159 95.60% [141, 142, 151, 152, 153, 209, 313]
🔵 com/starrocks/sql/optimizer/rule/implementation/IcebergScanImplementationRule.java 2 2 100.00% []
🔵 com/starrocks/connector/iceberg/QueueIcebergRemoteFileInfoSource.java 10 10 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/IcebergEqualityDeleteRewriteRule.java 84 84 100.00% []
🔵 com/starrocks/sql/optimizer/operator/logical/LogicalIcebergEqualityDeleteScanOperator.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/operator/logical/LogicalUnionOperator.java 7 7 100.00% []
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 8 8 100.00% []
🔵 com/starrocks/connector/iceberg/IcebergRemoteFileInfo.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/operator/physical/PhysicalIcebergScanOperator.java 8 8 100.00% []
🔵 com/starrocks/connector/CatalogConnectorMetadata.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/operator/logical/LogicalIcebergScanOperator.java 13 13 100.00% []
🔵 com/starrocks/connector/RemoteFileInfo.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/operator/physical/PhysicalIcebergEqualityDeleteScanOperator.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/rule/implementation/IcebergEqualityDeleteScanImplementationRule.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@dirtysalt dirtysalt enabled auto-merge (squash) October 25, 2024 06:00
@dirtysalt dirtysalt merged commit e666828 into StarRocks:main Oct 25, 2024
49 of 50 checks passed
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants