Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor MV Rewrite partition prune #52234

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[Refactor] Refactor MV Rewrite partition prune #52234

merged 2 commits into from
Oct 29, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Oct 23, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

  • Remove redundant codes & Refactor MV Rewrite partition prune to be better for extension.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing requested a review from a team as a code owner October 23, 2024 06:21
@LiShuMing LiShuMing force-pushed the fix/main/fix_mv_partition_prune branch 3 times, most recently from 140c132 to 9b8da69 Compare October 25, 2024 08:29
@LiShuMing LiShuMing force-pushed the fix/main/fix_mv_partition_prune branch from 8c3542f to d01d4cb Compare October 29, 2024 02:46
@LiShuMing
fix bugs
1cdee0a 
Signed-off-by: shuming.li <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 79 / 83 (95.18%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/operator/OpRuleBit.java 0 1 00.00% [17]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/rule/BaseMaterializedViewRewriteRule.java 10 12 83.33% [206, 219]
🔵 com/starrocks/sql/optimizer/operator/Operator.java 10 11 90.91% [328]
🔵 com/starrocks/sql/optimizer/Optimizer.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/PartitionPruneRule.java 3 3 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/ExternalScanPartitionPruneRule.java 3 3 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/compensation/OptCompensator.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java 10 10 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MVPartitionPruner.java 10 10 100.00% []
🔵 com/starrocks/sql/optimizer/Utils.java 3 3 100.00% []
🔵 com/starrocks/sql/optimizer/OptimizerTraceUtil.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedTimeSeriesRewriter.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/MaterializedViewTransparentRewriteRule.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewPushDownRewriter.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/MaterializationContext.java 3 3 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/rule/AggregateJoinPushDownRule.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/base/LogicalProperty.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MvPartitionCompensator.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing enabled auto-merge (squash) October 29, 2024 07:55
@LiShuMing LiShuMing merged commit 0b3f6c8 into StarRocks:main Oct 29, 2024
46 of 47 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_mv_partition_prune branch October 29, 2024 08:30
@LiShuMing
Copy link
Contributor Author

@mergify backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 31, 2024
@LiShuMing @mergify
[Refactor] Refactor MV Rewrite partition prune (#52234)
6139a7d 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 0b3f6c8)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewPushDownRewriter.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedTimeSeriesRewriter.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MVPartitionPruner.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvTimeSeriesRewriteWithOlapTest.java
@mergify mergify bot mentioned this pull request Oct 31, 2024
Closed
42 tasks
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@LiShuMing @ZiheLiu
[Refactor] Refactor MV Rewrite partition prune (StarRocks#52234)
c9dfcf3 
Signed-off-by: shuming.li <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@LiShuMing @renzhimin7
[Refactor] Refactor MV Rewrite partition prune (StarRocks#52234)
59eb936 
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
@wangsimo0
Copy link
Contributor

ignore backport check: 3.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@Seaven Seaven Seaven approved these changes

@satanson satanson satanson approved these changes

Assignees

@LiShuMing LiShuMing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiShuMing @wangsimo0 @satanson @Seaven