[Enhancement] Prune group bys and eliminate aggs by UK and FK #52201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiheLiu
force-pushed
the
opt/main/push_down_agg_refine2_ut
branch
4 times, most recently
from
b06c5d4
to
327a884
Compare
24 tasks
Seaven
previously approved these changes
Oct 23, 2024
LiShuMing
reviewed
Oct 29, 2024
| fnName.equals(FunctionSet.GROUP_CONCAT))) { | ||
| return false; | ||
| } | ||
| if (!context.getSessionVariable().isEnableUKFKOpt()) { |
There was a problem hiding this comment.
This is a behavior change? maybe we set enable_ukfk_opt = true by default later?
There was a problem hiding this comment.
Oh, this make a behavior change. Let me remove this check.
There was a problem hiding this comment.
Add a new session variable enable_eliminate_agg (default is true) to avoid behaviour changed.
| ColumnRefSet requiredOutputColumns = context.getTaskContext().getRequiredColumns(); | ||
| List<ColumnRefOperator> groupBys = aggOp.getGroupingKeys(); | ||
|
|
||
| // Retrieve non-UK columns from the first constraint that contains the UK column used in the GROUP BY clause. |
There was a problem hiding this comment.
Why only considers the first constraint, what if group by keys contain multi UKs from different tables?
There was a problem hiding this comment.
Good suggestions. Instead of checking the first constraint, check all the the constraints now.
github-actions
bot
added
the
documentation
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
ZiheLiu
force-pushed
the
opt/main/push_down_agg_refine2_ut
branch
from
8bb5913
to
5069650
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 180 / 183 (98.36%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Nov 4, 2024
LiShuMing
approved these changes
Nov 5, 2024
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…cks#52201) Signed-off-by: zihe.liu <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
To enhance table pruning and aggregation elimination for more scenarios, introduce the following two rules under the enable_ukfk_opt feature:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: