[BugFix] Fix "Connection pool shut down" in S3AFileSystem (backport #50816) #51321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Smith Cruise <[email protected]> (cherry picked from commit 9222444) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/credential/aws/AwsCloudConfigurationProvider.java # fe/fe-core/src/test/java/com/starrocks/credential/CloudConfigurationFactoryTest.java # fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java
|
Cherry-pick of 9222444 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
24 tasks
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix the below error when using S3AFileSystem +
aws.s3.use_aws_sdk_default_behavior=true.What I'm doing:
We have to implement DefaultCredentialsProvider by ourselves, otherwise we may face "java.lang.IllegalStateException: Connection pool shut down" error.
Hadoop S3AFileSystem will call
static AwsCredentialsProvider::create()to create CredentialsProvider.But in DefaultCredentialsProvider::create(), it will only return a global static variable.
If we close S3AFileSystem, it will also close CredentialsProvider.
For the next time we create a new S3AFileSystem, it will reuse previous closed CredentialsProvider, then error will be thrown.
You can check the details in link: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/troubleshooting.html#faq-connection-pool-shutdown-exception
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #50816 done by [Mergify](https://mergify.com). ## Why I'm doing: Fix the below error when using S3AFileSystem + `aws.s3.use_aws_sdk_default_behavior=true`.
What I'm doing:
We have to implement DefaultCredentialsProvider by ourselves, otherwise we may face "java.lang.IllegalStateException: Connection pool shut down" error.
Hadoop S3AFileSystem will call
static AwsCredentialsProvider::create()to create CredentialsProvider.But in DefaultCredentialsProvider::create(), it will only return a global static variable.
If we close S3AFileSystem, it will also close CredentialsProvider.
For the next time we create a new S3AFileSystem, it will reuse previous closed CredentialsProvider, then error will be thrown.
You can check the details in link: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/troubleshooting.html#faq-connection-pool-shutdown-exception
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: