Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] default current_timestamp broken after update to 3.3.2 from 3.2.10 (backport #50911) #51183

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

Why I'm doing:

default current_timestamp broken after update to 3.3.2 from 3.2.10

What I'm doing:

mysql> CREATE TABLE migrations ( version_id bigint(20) NOT NULL COMMENT "", id bigint(20) NOT NULL AUTO_INCREMENT COMMENT "", is_applied boolean NOT NULL COMMENT "", tstamp datetime NULL DEFAULT CURRENT_TIMESTAMP COMMENT "" ) ENGINE=OLAP PRIMARY KEY(version_id, id) DISTRIBUTED BY HASH(id) ORDER BY(version_id) PROPERTIES("replication_num" = "1");
Query OK, 0 rows affected (0.04 sec)

mysql> insert into migrations (version_id, is_applied) values (0, true);
Query OK, 1 row affected (0.39 sec)
{'label':'insert_2c42bf7a-6f3b-11ef-afc1-024253f5d68c', 'status':'VISIBLE', 'txnId':'2093'}

mysql> select * from migrations;
+------------+------+------------+---------------------+
| version_id | id | is_applied | tstamp |
+------------+------+------------+---------------------+
| 0 | 1 | 1 | 2024-09-10 11:39:00 |
+------------+------+------------+---------------------+
1 row in set (0.03 sec)

Fixes #50872

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50911 done by [Mergify](https://mergify.com). ## Why I'm doing: default current_timestamp broken after update to 3.3.2 from 3.2.10

What I'm doing:

mysql> CREATE TABLE migrations ( version_id bigint(20) NOT NULL COMMENT "", id bigint(20) NOT NULL AUTO_INCREMENT COMMENT "", is_applied boolean NOT NULL COMMENT "", tstamp datetime NULL DEFAULT CURRENT_TIMESTAMP COMMENT "" ) ENGINE=OLAP PRIMARY KEY(version_id, id) DISTRIBUTED BY HASH(id) ORDER BY(version_id) PROPERTIES("replication_num" = "1");
Query OK, 0 rows affected (0.04 sec)

mysql> insert into migrations (version_id, is_applied) values (0, true);
Query OK, 1 row affected (0.39 sec)
{'label':'insert_2c42bf7a-6f3b-11ef-afc1-024253f5d68c', 'status':'VISIBLE', 'txnId':'2093'}

mysql> select * from migrations;
+------------+------+------------+---------------------+
| version_id | id | is_applied | tstamp |
+------------+------+------------+---------------------+
| 0 | 1 | 1 | 2024-09-10 11:39:00 |
+------------+------+------------+---------------------+
1 row in set (0.03 sec)

Fixes #50872

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…3.2.10 (#50911)

Signed-off-by: Rohit Satardekar <[email protected]>
(cherry picked from commit 3f73bd0)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java
Copy link
Contributor Author

mergify bot commented Sep 20, 2024

Cherry-pick of 3f73bd0 has failed:

On branch mergify/bp/branch-3.2/pr-50911
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 3f73bd0ae3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Sep 20, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 20, 2024 01:57
@mergify mergify bot closed this Sep 20, 2024
auto-merge was automatically disabled September 20, 2024 01:57

Pull request was closed

Copy link
Contributor Author

mergify bot commented Sep 20, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@kevincai
Copy link
Contributor

@rohitrs1983 this should not be a problem on branch-3.2, so the backport to branch-3.2 is not necessary, right?

@rohitrs1983
Copy link
Contributor

@rohitrs1983 this should not be a problem on branch-3.2, so the backport to branch-3.2 is not necessary, right?

@kevincai yes. not required to backport to 3.2

@kevincai kevincai deleted the mergify/bp/branch-3.2/pr-50911 branch September 20, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants