[Enhancement] Support insert match column by name #51181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyb
force-pushed
the
insert_match_name
branch
2 times, most recently
from
7a3efe3
to
ad739d2
Compare
Signed-off-by: wyb <[email protected]>
wyb
force-pushed
the
insert_match_name
branch
from
ad739d2
to
06ee642
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 75 / 85 (88.24%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
meegoo
approved these changes
Oct 9, 2024
luohaha
approved these changes
Oct 23, 2024
Seaven
approved these changes
Oct 23, 2024
jaogoy
reviewed
Oct 23, 2024
| @@ -320,7 +320,7 @@ public enum ErrorCode { | |||
| "No partitions have data available for loading. If you are sure there may be no data to be loaded, " + | |||
| "you can use `ADMIN SET FRONTEND CONFIG ('empty_load_as_error' = 'false')` " + | |||
| "to ensure such load jobs can succeed"), | |||
| ERR_INSERTED_COLUMN_MISMATCH(5604, new byte[] {'2', '2', '0', '0', '0'}, | |||
| ERR_INSERT_COLUMN_COUNT_MISMATCH(5604, new byte[] {'2', '2', '0', '0', '0'}, | |||
| @@ -329,6 +329,7 @@ public enum ErrorCode { | |||
| ERR_ROUTINE_LOAD_OFFSET_INVALID(5607, new byte[] {'0', '2', '0', '0', '0'}, | |||
| "Consume offset: %d is greater than the latest offset: %d in kafka partition: %d. " + | |||
| "You can modify 'kafka_offsets' property through ALTER ROUTINE LOAD and RESUME the job"), | |||
| ERR_INSERT_COLUMN_NAME_MISMATCH(5608, new byte[] {'2', '2', '0', '0', '0'}, "%s column: %s has no matching %s column"), | |||
| } else { | ||
| Preconditions.checkState(insertStmt.isColumnMatchByName()); | ||
| if (query instanceof ValuesRelation) { | ||
| throw new SemanticException("Insert match column by name does not support values()"); |
There was a problem hiding this comment.
Why not use ErrorReport.reportSemanticException(42601, ...)
| mentionedColumns = | ||
| ((OlapTable) table).getBaseSchemaWithoutGeneratedColumn().stream() | ||
| .map(Column::getName).collect(Collectors.toSet()); | ||
| mentionedColumns.addAll(((OlapTable) table).getBaseSchemaWithoutGeneratedColumn().stream().map(Column::getName) |
There was a problem hiding this comment.
Can you tell me the reason to use addAll()?
There was a problem hiding this comment.
mentionedColumns is CASE_INSENSITIVE_ORDER set.
Collectors.toSet() returns hash set.
jaogoy
approved these changes
Oct 24, 2024
ZiheLiu
pushed a commit
to ZiheLiu/starrocks
that referenced
this pull request
Oct 31, 2024
Signed-off-by: wyb <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
Signed-off-by: wyb <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
currently, insert only supports matching column by position,
the order that values are inserted into the columns of the table is determined by the order that the columns were declared in values or select column list.
What I'm doing:
support matching by name.
this allows the order of the columns in the table differs from the order of the select columns in select statement.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: