Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix sync publish failed after BE restart (backport #51045) #51179

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Why I'm doing:

We will return publish success after tablet apply finished if we enable sync publish to avoid waiting apply during query. However, if BE restart, we will return publish success even though the apply is not finished. So the query may get query time out issue after BE restarted.

The reason is the transaction related tablets is lost after BE restart. For primary key table, if BE receive publish request, BE will delete committed rowset meta and rewrite rowset meta into TabletMeta, so the transaction related tablet info are lost if we restart BE during waiting apply finished.

What I'm doing:

If BE restarted, add the tablet which max_readable_version less than request_version into error_tablet_ids. Then the transaction will be visible until all those tablets apply finished.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51045 done by [Mergify](https://mergify.com). ## Why I'm doing: We will return publish success after tablet apply finished if we enable sync publish to avoid waiting apply during query. However, if BE restart, we will return publish success even though the apply is not finished. So the query may get `query time out` issue after BE restarted.

The reason is the transaction related tablets is lost after BE restart. For primary key table, if BE receive publish request, BE will delete committed rowset meta and rewrite rowset meta into TabletMeta, so the transaction related tablet info are lost if we restart BE during waiting apply finished.

What I'm doing:

If BE restarted, add the tablet which max_readable_version less than request_version into error_tablet_ids. Then the transaction will be visible until all those tablets apply finished.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wanpengfei-git wanpengfei-git merged commit a489f1e into branch-3.3 Sep 23, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-51045 branch September 23, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants