Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] avoid hudi context npe when cache reload in background (backport #50987) #51145

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[BugFix] avoid hudi context npe when cache reload in background (backport #50987) #51145

merged 1 commit into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

I see a lot of warning in fe.out

Sep 11, 2024 7:12:30 PM com.google.common.cache.LocalCache$Segment lambda$loadAsync$0
WARNING: Exception thrown during refresh
java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:592)
        at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:551)
        at com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:91)
        at com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:247)
        at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2345)
        at com.google.common.cache.LocalCache$Segment.lambda$loadAsync$0(LocalCache.java:2325)
        at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
        at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1286)
        at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1055)
        at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:807)
        at com.google.common.util.concurrent.AbstractTransformFuture.run(AbstractTransformFuture.java:105)
        at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
        at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:145)
        at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)
        at com.google.common.util.concurrent.ListenableFutureTask.done(ListenableFutureTask.java:113)
        at java.base/java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:381)
        at java.base/java.util.concurrent.FutureTask.setException(FutureTask.java:250)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:269)
        at com.starrocks.connector.ReentrantExecutor.lambda$execute$1(ReentrantExecutor.java:46)
        at com.starrocks.connector.BoundedExecutor.releaseQueue(BoundedExecutor.java:77)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
        at com.starrocks.connector.hudi.HudiRemoteFileIO.createHudiContext(HudiRemoteFileIO.java:61)
        at com.starrocks.connector.hudi.HudiRemoteFileIO.getRemoteFiles(HudiRemoteFileIO.java:99)
        at com.starrocks.connector.CachingRemoteFileIO.loadRemoteFiles(CachingRemoteFileIO.java:93)
        at com.starrocks.connector.CachingRemoteFileIO$1.load(CachingRemoteFileIO.java:54)
        at com.starrocks.connector.CachingRemoteFileIO$1.load(CachingRemoteFileIO.java:51)
        at com.google.common.cache.CacheLoader.reload(CacheLoader.java:100)
        at com.google.common.cache.CacheLoader$1.lambda$reload$0(CacheLoader.java:198)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        ... 5 more

It's because when cache reload in background, RemotePathKey does not have scan context object, which leads to NPE.

but in most cases, scan context has been set before listing files.

What I'm doing:

Create scan context when it's nullptr.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #50987 done by [Mergify](https://mergify.com). ## Why I'm doing:

I see a lot of warning in fe.out

Sep 11, 2024 7:12:30 PM com.google.common.cache.LocalCache$Segment lambda$loadAsync$0
WARNING: Exception thrown during refresh
java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:592)
        at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:551)
        at com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:91)
        at com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:247)
        at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2345)
        at com.google.common.cache.LocalCache$Segment.lambda$loadAsync$0(LocalCache.java:2325)
        at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
        at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1286)
        at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1055)
        at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:807)
        at com.google.common.util.concurrent.AbstractTransformFuture.run(AbstractTransformFuture.java:105)
        at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
        at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:145)
        at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)
        at com.google.common.util.concurrent.ListenableFutureTask.done(ListenableFutureTask.java:113)
        at java.base/java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:381)
        at java.base/java.util.concurrent.FutureTask.setException(FutureTask.java:250)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:269)
        at com.starrocks.connector.ReentrantExecutor.lambda$execute$1(ReentrantExecutor.java:46)
        at com.starrocks.connector.BoundedExecutor.releaseQueue(BoundedExecutor.java:77)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
        at com.starrocks.connector.hudi.HudiRemoteFileIO.createHudiContext(HudiRemoteFileIO.java:61)
        at com.starrocks.connector.hudi.HudiRemoteFileIO.getRemoteFiles(HudiRemoteFileIO.java:99)
        at com.starrocks.connector.CachingRemoteFileIO.loadRemoteFiles(CachingRemoteFileIO.java:93)
        at com.starrocks.connector.CachingRemoteFileIO$1.load(CachingRemoteFileIO.java:54)
        at com.starrocks.connector.CachingRemoteFileIO$1.load(CachingRemoteFileIO.java:51)
        at com.google.common.cache.CacheLoader.reload(CacheLoader.java:100)
        at com.google.common.cache.CacheLoader$1.lambda$reload$0(CacheLoader.java:198)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        ... 5 more

It's because when cache reload in background, RemotePathKey does not have scan context object, which leads to NPE.

but in most cases, scan context has been set before listing files.

What I'm doing:

Create scan context when it's nullptr.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 19, 2024

Cherry-pick of 7e9eb06 has failed:

On branch mergify/bp/branch-3.3/pr-50987
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 7e9eb06217.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/connector/RemoteFileScanContext.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/connector/RemotePathKey.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/connector/hudi/HudiRemoteFileIO.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/connector/RemoteFileOperationsTest.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Sep 19, 2024
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
24 tasks
@mergify mergify bot closed this Sep 19, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 19, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.3/pr-50987 branch September 19, 2024 06:10
@dirtysalt dirtysalt restored the mergify/bp/branch-3.3/pr-50987 branch September 19, 2024 07:40
@dirtysalt dirtysalt reopened this Sep 19, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 19, 2024 07:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wanpengfei-git wanpengfei-git merged commit 4f97fc8 into branch-3.3 Sep 19, 2024
30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-50987 branch September 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

Assignees

@dirtysalt dirtysalt

Labels
automerge conflicts version:3.3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirtysalt @wanpengfei-git