Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix the npe of show routine load (backport #50963) #51142

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[BugFix] Fix the npe of show routine load (backport #50963) #51142

merged 2 commits into from
Sep 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

What I'm doing:

2024-09-11 10:29:29.274+08:00 WARN (starrocks-mysql-nio-pool-0|199) [StmtExecutor.execute():749] execute Exception, sql show routine load
 java.lang.NullPointerException
        at com.starrocks.load.routineload.RoutineLoadJob.getShowInfo(RoutineLoadJob.java:1532)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
        at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.base/java.util.stream.StreamSpliterators$SliceSpliterator$OfRef.forEachRemaining(StreamSpliterators.java:740)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
        at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:952)
        at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:926)
        at java.base/java.util.stream.AbstractTask.compute(AbstractTask.java:327)
        at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:408)
        at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:736)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateParallel(ReduceOps.java:919)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
        at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
        at com.starrocks.qe.ShowExecutor$ShowExecutorVisitor.visitShowRoutineLoadStatement(ShowExecutor.java:1143)
        at com.starrocks.qe.ShowExecutor$ShowExecutorVisitor.visitShowRoutineLoadStatement(ShowExecutor.java:286)
        at com.starrocks.sql.ast.ShowRoutineLoadStmt.accept(ShowRoutineLoadStmt.java:169)
        at com.starrocks.sql.ast.AstVisitor.visit(AstVisitor.java:71)
        at com.starrocks.qe.ShowExecutor.execute(ShowExecutor.java:283)
        at com.starrocks.qe.StmtExecutor.handleShow(StmtExecutor.java:1698)
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:689)
        at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:360)
        at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:559)
        at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:894)
        at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:69)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #50963 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

2024-09-11 10:29:29.274+08:00 WARN (starrocks-mysql-nio-pool-0|199) [StmtExecutor.execute():749] execute Exception, sql show routine load
 java.lang.NullPointerException
        at com.starrocks.load.routineload.RoutineLoadJob.getShowInfo(RoutineLoadJob.java:1532)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
        at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.base/java.util.stream.StreamSpliterators$SliceSpliterator$OfRef.forEachRemaining(StreamSpliterators.java:740)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
        at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:952)
        at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:926)
        at java.base/java.util.stream.AbstractTask.compute(AbstractTask.java:327)
        at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:408)
        at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:736)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateParallel(ReduceOps.java:919)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
        at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
        at com.starrocks.qe.ShowExecutor$ShowExecutorVisitor.visitShowRoutineLoadStatement(ShowExecutor.java:1143)
        at com.starrocks.qe.ShowExecutor$ShowExecutorVisitor.visitShowRoutineLoadStatement(ShowExecutor.java:286)
        at com.starrocks.sql.ast.ShowRoutineLoadStmt.accept(ShowRoutineLoadStmt.java:169)
        at com.starrocks.sql.ast.AstVisitor.visit(AstVisitor.java:71)
        at com.starrocks.qe.ShowExecutor.execute(ShowExecutor.java:283)
        at com.starrocks.qe.StmtExecutor.handleShow(StmtExecutor.java:1698)
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:689)
        at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:360)
        at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:559)
        at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:894)
        at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:69)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@trueeyu @mergify
[BugFix] Fix the npe of show routine load (#50963)
8e78ff0 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 5bc037d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
#	fe/fe-core/src/test/java/com/starrocks/load/routineload/RoutineLoadJobTest.java
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 19, 2024

Cherry-pick of 5bc037d has failed:

On branch mergify/bp/branch-3.2/pr-50963
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 5bc037dadd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/load/routineload/PulsarRoutineLoadJob.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/load/routineload/RoutineLoadJobTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Sep 19, 2024
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 19, 2024 03:49
@mergify mergify bot closed this Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 03:49

Pull request was closed

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 19, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-50963 branch September 19, 2024 03:50
@trueeyu trueeyu restored the mergify/bp/branch-3.2/pr-50963 branch September 20, 2024 08:32
@trueeyu trueeyu reopened this Sep 20, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 20, 2024 08:32
@trueeyu
fix
b0401ec 
Signed-off-by: trueeyu <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wanpengfei-git wanpengfei-git merged commit 6eb366f into branch-3.2 Sep 20, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-50963 branch September 20, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

Assignees

@trueeyu trueeyu

Labels
automerge conflicts version:3.2.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueeyu @wanpengfei-git