Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix pushdown subfield with unstrict expression in project error (backport #51100) #51135

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Why I'm doing:

For unstrict expression with semi-type, e.g: coalesce(array...)/ifnull(array...), will push down the whole expression cross outer join, it's the wrong way, will take the result error
we should only push down array expression, not coalesce(array...), coalesce shoule stay in place

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51100 done by [Mergify](https://mergify.com). ## Why I'm doing:

For unstrict expression with semi-type, e.g: coalesce(array...)/ifnull(array...), will push down the whole expression cross outer join, it's the wrong way, will take the result error
we should only push down array expression, not coalesce(array...), coalesce shoule stay in place

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Sep 19, 2024

Cherry-pick of 2a85b7c has failed:

On branch mergify/bp/branch-3.1/pr-51100
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 2a85b7cb61.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/CloneDuplicateColRefRule.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregateTest.java
	modified:   fe/fe-core/src/test/resources/sql/tpch-histogram-cost/q14.sql
	modified:   fe/fe-core/src/test/resources/sql/tpchcost/q14.sql

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/prunesubfield/PushDownSubfieldRule.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/PruneComplexSubfieldTest.java
	both modified:   fe/fe-core/src/test/resources/sql/external/hive/tpch/q14.sql
	deleted by us:   fe/fe-core/src/test/resources/sql/scheduler/tpch/q14-2.sql
	deleted by us:   fe/fe-core/src/test/resources/sql/scheduler/tpch/q14.sql

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 19, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-51100 branch September 19, 2024 02:36
@Seaven Seaven restored the mergify/bp/branch-3.1/pr-51100 branch September 19, 2024 02:42
@Seaven Seaven reopened this Sep 19, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 19, 2024 02:43
@Seaven Seaven force-pushed the mergify/bp/branch-3.1/pr-51100 branch 3 times, most recently from 48d91ba to ea5ddbf Compare September 19, 2024 07:08
@Seaven Seaven force-pushed the mergify/bp/branch-3.1/pr-51100 branch from ea5ddbf to d6bf276 Compare September 19, 2024 08:12
Copy link

sonarcloud bot commented Sep 19, 2024

@wanpengfei-git wanpengfei-git merged commit df9cdfa into branch-3.1 Sep 19, 2024
29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-51100 branch September 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants