Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix broker load job hang when meet resource group pending timeout (backport #51072) #51127

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 18, 2024

Why I'm doing:

In previous PR #38183, we will skip cancel loading job when timeout happen. But when broker load met resource group pending timeout like:

com.starrocks.common.UserException: Failed to allocate resource to query: pending timeout [300], you could modify the session variable [query_queue_pending_timeout_second] to pending more time
at com.starrocks.qe.QueryQueueManager.maybeWait(QueryQueueManager.java:81) ~[starrocks-fe.jar:?]
at com.starrocks.qe.DefaultCoordinator.startScheduling(DefaultCoordinator.java:488) ~[starrocks-fe.jar:?]
at com.starrocks.qe.scheduler.Coordinator.startScheduling(Coordinator.java:102) ~[starrocks-fe.jar:?]
at com.starrocks.qe.scheduler.Coordinator.exec(Coordinator.java:85) ~[starrocks-fe.jar:?]

It's not a loading job timeout, but because error message contains timeout, so we will consider it as normal timeout and won't cancel it immediately, so load job will hang until timeout happens.

What I'm doing:

When we met resource group pending timeout, we can set it as USER_CANCEL, so we can cancel it immediately.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51072 done by [Mergify](https://mergify.com). ## Why I'm doing: In previous PR #38183, we will skip cancel loading job when timeout happen. But when broker load met resource group pending timeout like: ``` com.starrocks.common.UserException: Failed to allocate resource to query: pending timeout [300], you could modify the session variable [query_queue_pending_timeout_second] to pending more time at com.starrocks.qe.QueryQueueManager.maybeWait(QueryQueueManager.java:81) ~[starrocks-fe.jar:?] at com.starrocks.qe.DefaultCoordinator.startScheduling(DefaultCoordinator.java:488) ~[starrocks-fe.jar:?] at com.starrocks.qe.scheduler.Coordinator.startScheduling(Coordinator.java:102) ~[starrocks-fe.jar:?] at com.starrocks.qe.scheduler.Coordinator.exec(Coordinator.java:85) ~[starrocks-fe.jar:?] ```

It's not a loading job timeout, but because error message contains timeout, so we will consider it as normal timeout and won't cancel it immediately, so load job will hang until timeout happens.

What I'm doing:

When we met resource group pending timeout, we can set it as USER_CANCEL, so we can cancel it immediately.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Sep 18, 2024

@wanpengfei-git wanpengfei-git merged commit 6625e8c into branch-3.2 Sep 18, 2024
36 of 37 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-51072 branch September 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants