Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove column pool #51105

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 18, 2024

Why I'm doing:

ColumnPool is designed to address performance issues caused by frequent cross thread memory alloc/free.

Tcmalloc has a CentrlHeap, which results in high lock contention overhead. Currently it has been already been replaced by Jemalloc, which is now an independent arena and no longer has this issue. In version 3.2, ColumnPool` has been disabled by default, and there have been no performance issues in performance testing or user production environments.

So in main branch, it can be safely removed.

What I'm doing:

Remove column pool

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 20, 2024

@Mergifyio rebase main

Copy link
Contributor

mergify bot commented Sep 20, 2024

rebase main

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Copy link

sonarcloud bot commented Sep 20, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 14 / 22 (63.64%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/connector/lake_connector.cpp 0 1 00.00% [136]
🔵 be/src/exec/olap_scan_node.cpp 0 4 00.00% [211, 271, 274, 732]
🔵 be/src/common/daemon.cpp 0 3 00.00% [176, 177, 178]
🔵 be/src/storage/chunk_helper.cpp 13 13 100.00% []
🔵 be/src/exec/pipeline/scan/olap_chunk_source.cpp 1 1 100.00% []

@alvin-celerdata alvin-celerdata merged commit 37d72ac into StarRocks:main Sep 20, 2024
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants