-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix DataDir invalid access, refactor DataDir management #51063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincai
force-pushed
the
fix-be-crash-datadir
branch
from
September 14, 2024 14:32
a9b389f
to
9a2fbb0
Compare
* release DataDir in StorageEngine destructor * manage DataDir with unique_ptr to ease the memory deallocation Signed-off-by: Kevin Xiaohua Cai <[email protected]>
kevincai
force-pushed
the
fix-be-crash-datadir
branch
from
September 18, 2024 04:37
9a2fbb0
to
5e8819f
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 9 / 14 (64.29%) file detail
|
trueeyu
approved these changes
Sep 19, 2024
wyb
approved these changes
Sep 20, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
) Signed-off-by: Kevin Xiaohua Cai <[email protected]> (cherry picked from commit 92d1be9)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
) Signed-off-by: Kevin Xiaohua Cai <[email protected]> (cherry picked from commit 92d1be9)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…kport #51063) (#51205) Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…kport #51063) (#51206) Co-authored-by: Kevin Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: