[Enhancement]explicit specific arrow use avx2 as default #51038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueeyu
approved these changes
Sep 14, 2024
|
@mergify rebase |
❌ Unable to rebase: user
|
Signed-off-by: zombee0 <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
wangruin
approved these changes
Sep 19, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: zombee0 <[email protected]> (cherry picked from commit 1f4e238)
42 tasks
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Hitherto, we use default configuration of arrow, which means ARROW_SIMD_LEVEL=SSE4_2
and ARROW_RUNTIME_SIMD_LEVEL=MAX, there are two issues, 1. avx2 may have better
performance, 2. even arrow specific SSE4_2 as default compile configuration, it uses xsimd
which use avx512 as default configuration, and because the ARROW_RUNTIME_SIMD_LEVEL=MAX
in some case, the performance is bad.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: