Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add command to show the dropped meta information that can be recovered #51007

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Enhancement] add command to show the dropped meta information that can be recovered #51007

wants to merge 3 commits into from
+465 −2

Conversation

rohitrs1983
Copy link
Contributor

@rohitrs1983 rohitrs1983 commented Sep 12, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

image

Fixes #51006

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@rohitrs1983 rohitrs1983 requested review from a team as code owners September 12, 2024 13:38
@kevincai
Copy link
Contributor

fantastic!

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 46 / 88 (52.27%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/ast/ShowCatalogRecycleBinStmt.java 0 15 00.00% [25, 26, 27, 28, 29, 30, 31, 32, 33, 36, 37, 40, 41, 45, 50]
🔵 com/starrocks/sql/ast/AstVisitor.java 0 1 00.00% [1477]
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 0 11 00.00% [2525, 2526, 2528, 2529, 2530, 2532, 2533, 2534, 2535, 2536, 2537]
🔵 com/starrocks/qe/ShowExecutor.java 0 3 00.00% [2682, 2683, 2684]
🔵 com/starrocks/catalog/CatalogRecycleBin.java 46 58 79.31% [927, 928, 929, 931, 950, 951, 952, 954, 973, 974, 975, 977]

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 21, 2024

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rohitrs1983 rohitrs1983

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] add command to show the dropped meta information that can be recovered
2 participants
@rohitrs1983 @kevincai