Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix backup and restore Case-Sensitive Table Name Conflict #50979

Closed
wants to merge 1 commit into from

Conversation

rohitrs1983
Copy link
Contributor

@rohitrs1983 rohitrs1983 commented Sep 11, 2024

Why I'm doing:

What I'm doing:

Fix backup and restore Case-Sensitive Table Name Conflict

mysql> BACKUP SNAPSHOT mydb.db_backup to s3_repo;
Query OK, 0 rows affected (0.08 sec)

mysql> SHOW BACKUP;
+-------+--------------+--------+----------+----------------------------------------------------------------------------------------------------------------------------------+---------------------+----------------------+---------------------+---------------------+-----------------+----------+------------+--------+---------+
| JobId | SnapshotName | DbName | State    | BackupObjs                                                                                                                       | CreateTime          | SnapshotFinishedTime | UploadFinishedTime  | FinishedTime        | UnfinishedTasks | Progress | TaskErrMsg | Status | Timeout |
+-------+--------------+--------+----------+----------------------------------------------------------------------------------------------------------------------------------+---------------------+----------------------+---------------------+---------------------+-----------------+----------+------------+--------+---------+
| 20011 | db_backup    | mydb   | FINISHED | [mydb.My_table], [mydb.my_table], [mydb.test_t1], [mydb.test_t2], [mydb.test_t3], [mydb.test_t4], [mydb.test_t5], [mydb.test_t6] | 2024-09-12 01:18:20 | 2024-09-12 01:18:25  | 2024-09-12 01:18:52 | 2024-09-12 01:18:58 |                 |          |            | [OK]   | 86400   |
+-------+--------------+--------+----------+----------------------------------------------------------------------------------------------------------------------------------+---------------------+----------------------+---------------------+---------------------+-----------------+----------+------------+--------+---------+

mysql> SHOW SNAPSHOT ON s3_repo;
+-----------+-------------------------+--------+
| Snapshot  | Timestamp               | Status |
+-----------+-------------------------+--------+
| db_backup | 2024-09-12-01-18-20-455 | OK     |
+-----------+-------------------------+--------+

mysql> drop table my_table;

mysql> drop table My_table;

mysql> RESTORE SNAPSHOT mydb.db_backup FROM s3_repo ON (My_table, my_table)  PROPERTIES("backup_timestamp"="2024-09-12-01-18-20-455", "replication_num" = "1");

mysql> select * from My_table;
+------------+------+------+
| date       | k1   | k2   |
+------------+------+------+
| 2022-03-11 |    3 | abc  |
| 2022-03-11 |    2 | acb  |
| 2022-03-11 |    4 | abc  |
| 2022-03-12 |    2 | bca  |
| 2022-03-12 |    4 | cba  |
| 2022-03-12 |    5 | cba  |
+------------+------+------+

mysql> select * from my_table;
+------------+------+------+
| date       | k1   | k2   |
+------------+------+------+
| 2022-03-12 |    2 | bca  |
| 2022-03-12 |    4 | cba  |
| 2022-03-12 |    5 | cba  |
| 2022-03-11 |    3 | abc  |
| 2022-03-11 |    2 | acb  |
| 2022-03-11 |    4 | abc  |
+------------+------+------+

Fixes #50949

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@rohitrs1983 rohitrs1983 requested a review from a team as a code owner September 11, 2024 20:33
@github-actions github-actions bot added the 3.3 label Sep 11, 2024
Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/BackupRestoreAnalyzer.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@chaoyli
Copy link
Contributor

chaoyli commented Sep 18, 2024

@rohitrs1983 Thanks for your contribution. It seems conflict with #51068. He had add more tests in the code and the first contribution. Do you mind to close this pull request? Thanks in advance.

@rohitrs1983
Copy link
Contributor Author

@rohitrs1983 Thanks for your contribution. It seems conflict with #51068. He had add more tests in the code and the first contribution. Do you mind to close this pull request? Thanks in advance.

ok sure. closing PR as duplicate of #51068

@allencelerdata
Copy link

Thanks @rohitrs1983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup Fails Due to Case-Sensitive Table Name Conflict
3 participants