Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]enhance bit unpacking with bmi2 instruction set #50904

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Sep 10, 2024

Why I'm doing:

What I'm doing:

accelerating bit unpacking in starrocks with simd implementation
ssbflat 10 concurrency, 100g, parquet/3*16c64g improvement 6%.

query original optimized
q01 7435 6917
q02 6329 5995
q03 7481 7132
q04 6034 5751
q05 5345 5216
q06 3284 3168
q07 8225 7921
q08 6851 6341
q09 3225 2781
q10 2713 2285
q11 9113 8836
q12 9680 8941
q13 7390 7052
sum 83105 78336

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zombee0 zombee0 requested a review from a team as a code owner September 10, 2024 06:03
@zombee0 zombee0 marked this pull request as draft September 10, 2024 07:30
@zombee0 zombee0 marked this pull request as ready for review September 14, 2024 07:05
@zombee0 zombee0 requested a review from a team as a code owner September 18, 2024 13:09
@zombee0 zombee0 changed the title [Enhancement]simd for bit unpacking from arrow [Enhancement]enhance bit unpacking with bmi2 instruction set Sep 19, 2024
Signed-off-by: zombee0 <[email protected]>
Signed-off-by: zombee0 <[email protected]>
Copy link

sonarcloud bot commented Sep 20, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 115 / 171 (67.25%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/bit_packing_simd.h 96 151 63.58% [266, 268, 270, 271, 272, 273, 274, 275, 277, 280, 281, 282, 283, 284, 286, 287, 288, 289, 290, 291, 292, 294, 295, 297, 300, 301, 302, 304, 305, 306, 311, 313, 314, 315, 319, 320, 324, 326, 327, 328, 329, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438]
🔵 be/src/util/bit_packing_adapter.h 17 18 94.44% [65]
🔵 be/src/util/bit_stream_utils.inline.h 2 2 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants