Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add config to turn on balancing tablets between workers in shared-data mode #50843

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[Enhancement] add config to turn on balancing tablets between workers in shared-data mode #50843

merged 1 commit into from
Sep 10, 2024

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Sep 9, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
[Enhancement] add config to turn on balancing tablets between workers…
415f6e2 
… in shared-data mode

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@github-actions github-actions bot added the 3.3 label Sep 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[FE Incremental Coverage Report]

✅ pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Config.java 2 2 100.00% []
🔵 com/starrocks/staros/StarMgrServer.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb enabled auto-merge (squash) September 10, 2024 06:10
@wyb wyb merged commit 5dbaaf5 into StarRocks:main Sep 10, 2024
49 of 50 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@kevincai @mergify
[Enhancement] Add config to turn on balancing tablets between workers…
1309ae2 
… in shared-data mode (#50843)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 5dbaaf5)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
42 tasks
HangyuanLiu pushed a commit to HangyuanLiu/starrocks that referenced this pull request Sep 12, 2024
@kevincai @HangyuanLiu
[Enhancement] Add config to turn on balancing tablets between workers…
fd9bdb5 
… in shared-data mode (StarRocks#50843)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 18, 2024
@mergify @kevincai
[Enhancement] add config to turn on balancing tablets between workers…
7a970c4 
… in shared-data mode (backport #50843) (#50913)

Co-authored-by: Kevin Cai <[email protected]>
@kevincai
Copy link
Contributor Author

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@kevincai @mergify
[Enhancement] Add config to turn on balancing tablets between workers…
364f268 
… in shared-data mode (#50843)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 5dbaaf5)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 20, 2024
@mergify @kevincai
[Enhancement] add config to turn on balancing tablets between workers…
055dc40 
… in shared-data mode (backport #50843) (#51212)

Co-authored-by: Kevin Cai <[email protected]>
@kevincai kevincai mentioned this pull request Sep 24, 2024
Merged
24 tasks
@mergify mergify bot mentioned this pull request Sep 25, 2024
Merged
42 tasks
@kevincai kevincai deleted the add-configvar-enable-balance-shared-data branch October 19, 2024 08:20
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@kevincai @renzhimin7
[Enhancement] Add config to turn on balancing tablets between workers…
003339f 
… in shared-data mode (StarRocks#50843)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-xupeng starrocks-xupeng starrocks-xupeng approved these changes

@wyb wyb wyb approved these changes

@decster decster decster approved these changes

Assignees

@kevincai kevincai

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevincai @decster @wyb @starrocks-xupeng