Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] improve return filename from delta column group by index (backport #50596) #50704

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2024

Why I'm doing:

What I'm doing:

I introduce column_file_by_idx to return filename delta column group by index, it will be more efficient than use column_files to return filename array.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50596 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

I introduce column_file_by_idx to return filename delta column group by index, it will be more efficient than use column_files to return filename array.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

#50596)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 17e9d4c)

# Conflicts:
#	be/src/storage/delta_column_group.h
#	be/src/storage/rowset/segment.cpp
#	be/test/storage/delta_column_group_test.cpp
#	be/test/storage/lake/meta_file_test.cpp
@mergify mergify bot added the conflicts label Sep 4, 2024
Copy link
Contributor Author

mergify bot commented Sep 4, 2024

Cherry-pick of 17e9d4c has failed:

On branch mergify/bp/branch-3.2/pr-50596
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 17e9d4cc69.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/storage/rowset/segment_iterator.cpp
	modified:   be/src/storage/tablet_updates.cpp
	modified:   be/test/storage/tablet_meta_manager_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/delta_column_group.h
	both modified:   be/src/storage/rowset/segment.cpp
	both modified:   be/test/storage/delta_column_group_test.cpp
	both modified:   be/test/storage/lake/meta_file_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 4, 2024 17:06
@mergify mergify bot closed this Sep 4, 2024
auto-merge was automatically disabled September 4, 2024 17:06

Pull request was closed

Copy link
Contributor Author

mergify bot commented Sep 4, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-50596 branch September 4, 2024 17:07
@luohaha luohaha restored the mergify/bp/branch-3.2/pr-50596 branch September 27, 2024 04:47
@luohaha luohaha reopened this Sep 27, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 27, 2024 04:48
Signed-off-by: Yixin Luo <[email protected]>
luohaha
luohaha previously approved these changes Sep 27, 2024
Signed-off-by: Yixin Luo <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 869bca5 into branch-3.2 Sep 27, 2024
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-50596 branch September 27, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants