Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] add null value count to iceberg value count #50699

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[BugFix] add null value count to iceberg value count #50699

merged 1 commit into from
Sep 5, 2024

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Sep 4, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue
The num_values() of arrow parquet statistics is non-null in the column. we need to add null value count to iceberg metrics. so we can do a correct data skipping.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stephen-shelby stephen-shelby requested a review from a team as a code owner September 4, 2024 16:05
@stephen-shelby stephen-shelby changed the title [BugFix] add null value count to iceberg value count [UT] add null value count to iceberg value count Sep 5, 2024
@stephen-shelby stephen-shelby changed the title [UT] add null value count to iceberg value count [BugFix] add null value count to iceberg value count Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/parquet_file_writer.cpp 1 1 100.00% []

@stephen-shelby stephen-shelby merged commit 37ef12f into StarRocks:main Sep 5, 2024
76 of 78 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 5, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 5, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 5, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 5, 2024
@stephen-shelby @mergify
[BugFix] add null value count to iceberg value count (#50699)
3b43759 
Signed-off-by: stephen <[email protected]>
(cherry picked from commit 37ef12f)
mergify bot pushed a commit that referenced this pull request Sep 5, 2024
@stephen-shelby @mergify
[BugFix] add null value count to iceberg value count (#50699)
98f9a39 
Signed-off-by: stephen <[email protected]>
(cherry picked from commit 37ef12f)

# Conflicts:
#	be/src/formats/parquet/parquet_file_writer.cpp
mergify bot pushed a commit that referenced this pull request Sep 5, 2024
@stephen-shelby @mergify
[BugFix] add null value count to iceberg value count (#50699)
60a84fc 
Signed-off-by: stephen <[email protected]>
(cherry picked from commit 37ef12f)

# Conflicts:
#	be/src/formats/parquet/parquet_file_writer.cpp
This was referenced Sep 5, 2024
Merged
Closed
Closed
wanpengfei-git pushed a commit that referenced this pull request Sep 6, 2024
@mergify @stephen-shelby
[BugFix] add null value count to iceberg value count (backport #50699) (
c230fd7 
#50743)

Co-authored-by: stephen <[email protected]>
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
@mergify @stephen-shelby @xiangguangyxg
[BugFix] add null value count to iceberg value count (backport StarRo…
3e98bbb 
…cks#50699) (StarRocks#50743)

Co-authored-by: stephen <[email protected]>
@github-actions github-actions bot added the 3.3 label Sep 27, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@stephen-shelby @renzhimin7
[BugFix] add null value count to iceberg value count (StarRocks#50699)
0ebd4a6 
Signed-off-by: stephen <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youngwb Youngwb Youngwb approved these changes

@dirtysalt dirtysalt dirtysalt approved these changes

Assignees

@stephen-shelby stephen-shelby

Labels
3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-shelby @dirtysalt @Youngwb