[Enhancement] Optimize memory tracker (backport #49841) #50694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
## Why I'm doing: Currently, memory statistics consume a lot of performance because they are all calculated each time. ## What I'm doing: Get some samples to estimate the manager's memory, even though it is inaccurate, but it's helpful to solve memory leak bugs. Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f0cb5e9) # Conflicts: # contrib/destination-starrocks/src/main/java/io/airbyte/integrations/destination/starrocks/StreamLoader.java # fe/fe-core/src/main/java/com/starrocks/catalog/Database.java # fe/fe-core/src/main/java/com/starrocks/common/util/ProfileManager.java # fe/fe-core/src/main/java/com/starrocks/connector/CatalogConnector.java # fe/fe-core/src/main/java/com/starrocks/connector/Connector.java # fe/fe-core/src/main/java/com/starrocks/connector/delta/CachingDeltaLakeMetastore.java # fe/fe-core/src/main/java/com/starrocks/connector/delta/DeltaLakeMetastore.java # fe/fe-core/src/main/java/com/starrocks/connector/iceberg/CachingIcebergCatalog.java # fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergCatalog.java # fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergConnector.java # fe/fe-core/src/main/java/com/starrocks/connector/jdbc/JDBCTableIdCache.java # fe/fe-core/src/main/java/com/starrocks/lake/compaction/CompactionMgr.java # fe/fe-core/src/main/java/com/starrocks/leader/ReportHandler.java # fe/fe-core/src/main/java/com/starrocks/load/InsertOverwriteJobMgr.java # fe/fe-core/src/main/java/com/starrocks/memory/InternalCatalogMemoryTracker.java # fe/fe-core/src/main/java/com/starrocks/memory/MemoryTrackable.java # fe/fe-core/src/main/java/com/starrocks/memory/MemoryUsageTracker.java # fe/fe-core/src/main/java/com/starrocks/qe/QeProcessorImpl.java # fe/fe-core/src/main/java/com/starrocks/scheduler/TaskManager.java # fe/fe-core/src/main/java/com/starrocks/scheduler/TaskRunManager.java # fe/fe-core/src/main/java/com/starrocks/scheduler/history/TaskRunHistory.java # fe/fe-core/src/main/java/com/starrocks/transaction/GlobalTransactionMgr.java # fe/fe-core/src/main/java/com/starrocks/warehouse/WarehouseClusterProcNode.java # fe/fe-core/src/test/java/com/starrocks/connector/delta/CachingDeltaLakeMetastoreTest.java # fe/fe-core/src/test/java/com/starrocks/connector/delta/DeltaLakeConnectorTest.java
|
Cherry-pick of f0cb5e9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
26 tasks
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
|
gengjun-git
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently, memory statistics consume a lot of performance because they are all calculated each time.
What I'm doing:
Get some samples to estimate the manager's memory, even though it is inaccurate, but it's helpful to solve memory leak bugs.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Documentation PRs only:
If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.
This is an automatic backport of pull request #49841 done by [Mergify](https://mergify.com). ## Why I'm doing: Currently, memory statistics consume a lot of performance because they are all calculated each time.
What I'm doing:
Get some samples to estimate the manager's memory, even though it is inaccurate, but it's helpful to solve memory leak bugs.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: