-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Clear probe RF whose probe expr contains dict mapping expr #50690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Seaven
approved these changes
Sep 4, 2024
stdpain
approved these changes
Sep 4, 2024
satanson
approved these changes
Sep 4, 2024
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 17 / 17 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 12 / 12 (100.00%) file detail
|
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…50690) Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit a810948) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/planner/ProjectNode.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest.java
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…50690) Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit a810948) # Conflicts: # be/src/exprs/runtime_filter_bank.cpp # fe/fe-core/src/main/java/com/starrocks/planner/ProjectNode.java
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…50690) Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit a810948) # Conflicts: # be/src/exprs/runtime_filter_bank.cpp # fe/fe-core/src/main/java/com/starrocks/planner/ProjectNode.java
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…50690) Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit a810948) # Conflicts: # be/src/exprs/vectorized/runtime_filter_bank.cpp # fe/fe-core/src/main/java/com/starrocks/planner/ProjectNode.java
42 tasks
24 tasks
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 5, 2024
…tarRocks#50690) Signed-off-by: zihe.liu <[email protected]>
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 5, 2024
…tarRocks#50690) Signed-off-by: zihe.liu <[email protected]>
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 5, 2024
…tarRocks#50690) Signed-off-by: zihe.liu <[email protected]>
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 5, 2024
…tarRocks#50690) Signed-off-by: zihe.liu <[email protected]>
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 5, 2024
…tarRocks#50690) Signed-off-by: zihe.liu <[email protected]>
This was referenced Sep 5, 2024
satanson
pushed a commit
that referenced
this pull request
Sep 5, 2024
…backport #50690) (#50724) Signed-off-by: zihe.liu <[email protected]>
satanson
pushed a commit
that referenced
this pull request
Sep 5, 2024
…backport #50690) (#50725) Signed-off-by: zihe.liu <[email protected]>
satanson
pushed a commit
that referenced
this pull request
Sep 5, 2024
…backport #50690) (#50727) Signed-off-by: zihe.liu <[email protected]>
satanson
pushed a commit
that referenced
this pull request
Sep 5, 2024
…backport #50690) (#50726) Signed-off-by: zihe.liu <[email protected]>
satanson
pushed a commit
that referenced
this pull request
Sep 5, 2024
…backport #50690) (#50728) Signed-off-by: zihe.liu <[email protected]>
xiangguangyxg
pushed a commit
to xiangguangyxg/starrocks
that referenced
this pull request
Sep 6, 2024
…backport StarRocks#50690) (StarRocks#50724) Signed-off-by: zihe.liu <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…tarRocks#50690) Signed-off-by: zihe.liu <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If the equi-join predicate is derived from an expression evaluated on a column with low cardinality, a corresponding runtime filter will be generated on the
OlapScanNode.
The probe expression for this filter is aDictMappingExpr
.Except for the main branch, this
DictMappingExpr
in the probe expression is not rewritten, leading to a crash when evaluated using a DictID column.Plan:
What I'm doing:
To address this case, a check is performed in the
ProjectNode
. If an expression contains aDictMappingExpr
, the RF will be no longer pushed down to its children.Additionally, both FE and BE have implemented a fallback strategy to remove all probe runtime filters that include a
DictMappingExpr
in the probe expression.Plan after this PR:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: