Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support to pushdown compound predicates in orc (backport #50613) #50667

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2024

Why I'm doing:

We can't push down a=1 or b=1 compound predicates in orc reader before.

What I'm doing:

  • Support pushdown compound predicates
  • Remove unused variables in IcebergDeleteBuilder

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50613 done by [Mergify](https://mergify.com). ## Why I'm doing: We can't push down `a=1 or b=1` compound predicates in orc reader before.

What I'm doing:

  • Support pushdown compound predicates
  • Remove unused variables in IcebergDeleteBuilder

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 8bf333e)

# Conflicts:
#	be/src/exec/hdfs_scanner.cpp
#	be/src/exec/hdfs_scanner.h
#	be/src/exec/hdfs_scanner_orc.cpp
#	be/src/exec/hdfs_scanner_parquet.cpp
#	be/src/exec/iceberg/iceberg_delete_builder.h
@mergify mergify bot added the conflicts label Sep 4, 2024
Copy link
Contributor Author

mergify bot commented Sep 4, 2024

Cherry-pick of 8bf333e has failed:

On branch mergify/bp/branch-3.0/pr-50613
Your branch is up to date with 'origin/branch-3.0'.

You are currently cherry-picking commit 8bf333e5fd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/connector/hive_connector.cpp
	modified:   be/test/exec/hdfs_scanner_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exec/hdfs_scanner.cpp
	both modified:   be/src/exec/hdfs_scanner.h
	both modified:   be/src/exec/hdfs_scanner_orc.cpp
	both modified:   be/src/exec/hdfs_scanner_parquet.cpp
	both modified:   be/src/exec/iceberg/iceberg_delete_builder.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 4, 2024 03:03
@mergify mergify bot closed this Sep 4, 2024
auto-merge was automatically disabled September 4, 2024 03:03

Pull request was closed

Copy link
Contributor Author

mergify bot commented Sep 4, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.0/pr-50613 branch September 4, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant