Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Starrocks to support function SESSION_USER() (backport #50513) #50663

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2024

Why I'm doing:

What I'm doing:

Added support for new scalar function session_user()

when run sqlmap tool on Starrocks master it gave error like session_user() function not found. mysql support this function.
https://www.w3schools.com/sql/func_mysql_session_user.asp
Its similar to Starrocks user() function.

MySQL [(none)]> select session_user();
+--------------------+
| SESSION_USER()     |
+--------------------+
| 'root'@'127.0.0.1' |
+--------------------+
1 row in set (0.007 sec)

Fixes #50512

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50513 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Added support for new scalar function session_user()

when run sqlmap tool on Starrocks master it gave error like session_user() function not found. mysql support this function.
https://www.w3schools.com/sql/func_mysql_session_user.asp
Its similar to Starrocks user() function.

MySQL [(none)]> select session_user();
+--------------------+
| SESSION_USER()     |
+--------------------+
| 'root'@'127.0.0.1' |
+--------------------+
1 row in set (0.007 sec)

Fixes #50512

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Rohit Satardekar <[email protected]>
(cherry picked from commit 1def993)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
@mergify mergify bot added the conflicts label Sep 4, 2024
Copy link
Contributor Author

mergify bot commented Sep 4, 2024

Cherry-pick of 1def993 has failed:

On branch mergify/bp/branch-3.2/pr-50513
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 1def993fb6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/FunctionSet.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/ExpressionAnalyzer.java
	modified:   fe/fe-core/src/test/java/com/starrocks/analysis/SelectStmtTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 4, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-50513 branch September 4, 2024 02:51
@nshangyiming nshangyiming restored the mergify/bp/branch-3.2/pr-50513 branch September 6, 2024 08:36
@nshangyiming nshangyiming reopened this Sep 6, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 6, 2024 08:37
Copy link

sonarcloud bot commented Sep 6, 2024

@wanpengfei-git wanpengfei-git merged commit 7694269 into branch-3.2 Sep 23, 2024
30 of 31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-50513 branch September 23, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants