[BugFix] Fix decimal literal equals uncheck type (backport #50626) #50660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
sum(gmv * 1.00000000000)
:1.00000000000
isDECIMAL64(12, 11)
Literalsum(gmv * 1.000)
:1.000
isDECIMAL32(4, 3)
Literalequals method check
1.00000000000
is same as1.000
, but the results of hashcode method is different.In analyze, will check duplicate expression by list.contains, only use equals method, then two expression will be reduce to one, but in QueryTransform, use HashMap to find expression, it's will take can't find expression because hashcode is different.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #50626 done by [Mergify](https://mergify.com). ## Why I'm doing: ![image](https://github.com/user-attachments/assets/f19909f9-8570-4dd1-8759-289ea6a56308)
sum(gmv * 1.00000000000)
:1.00000000000
isDECIMAL64(12, 11)
Literalsum(gmv * 1.000)
:1.000
isDECIMAL32(4, 3)
Literalequals method check
1.00000000000
is same as1.000
, but the results of hashcode method is different.In analyze, will check duplicate expression by list.contains, only use equals method, then two expression will be reduce to one, but in QueryTransform, use HashMap to find expression, it's will take can't find expression because hashcode is different.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: