[Enhancement] Support insert timeout #50644
Open
+264
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaogoy
reviewed
Sep 5, 2024
| @@ -1303,6 +1304,7 @@ private void handleAnalyzeStmt() throws IOException { | |||
| // will print warning log if timeout, so we update timeout temporarily to avoid | |||
| // warning log | |||
| context.getSessionVariable().setQueryTimeoutS((int) Config.statistic_collect_query_timeout); | |||
| context.getSessionVariable().setInsertTimeoutS((int) Config.statistic_collect_query_timeout); | |||
There was a problem hiding this comment.
analyze job has both query and insert sql, so set query_timeout and insert_timeout
| String.format("Query exceeded time limit of %d seconds", | ||
| ConnectContext.get().getSessionVariable().getQueryTimeoutS()))); | ||
| status.setStatus(new Status(TStatusCode.TIMEOUT, ErrorCode.ERR_TIMEOUT.formatErrorMsg( | ||
| "Query", timeoutMs / 1000, "please increase the 'query_timeout' session variable"))); |
There was a problem hiding this comment.
yes, only query uses this.
| } | ||
|
|
||
| public String getExecType() { | ||
| if (parsedStmt instanceof InsertStmt || parsedStmt instanceof CreateTableAsSelectStmt) { |
There was a problem hiding this comment.
Why not implement it as a method in StatementBase?
And provide a StmtExecType class with DML_INSERT, DML_UPDATE, DML_DELETE, DCL_QUERY
| @@ -2689,4 +2693,28 @@ public void addFinishedQueryDetail() { | |||
| QueryDetailQueue.addQueryDetail(queryDetail); | |||
| } | |||
|
|
|||
| public int getExecTimeout() { | |||
| if (parsedStmt instanceof DmlStmt) { | |||
There was a problem hiding this comment.
Is it better to provide a abstract getTimeout method in StatementBase, with some sub-classes implementing it?
wyb
force-pushed
the
ins_timeout
branch
2 times, most recently
from
10874fd
to
a76bca3
Compare
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 59 / 79 (74.68%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
insertandqueryuse the samequery_timeoutsession variable to control timeout.but they need different default values, default
query_timeout 300sis very small for insert.What I'm doing:
add a new
insert_timeoutsession variable forinsert/update/deleteand the default value is14400s.you can also set
timeoutininsert propertiesfor the current insert sql, for exampleif
timeoutproperty is not set,insert_timeoutsession variable will be used.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: