[Enhancement] Support Async delete files from Recycle Bin in shared data mode #50636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| }, LakeTableHelper.ASYNC_REMOVE_PARTITION_EXECUTOR)); | ||
| } | ||
| } | ||
|
|
||
| public static boolean isSharedPartitionDirectory(PhysicalPartition partition, long warehouseId) throws StarClientException { | ||
| ShardInfo shardInfo = getAssociatedShardInfo(partition, warehouseId).orElse(null); | ||
| if (shardInfo == null) { |
There was a problem hiding this comment.
The most risky bug in this code is:
Concurrency issue with RUNNING_DELETE_TABLE map.
You can modify the code like this:
static boolean submitAndCheckAsyncDeleteTableFromRecycleBin(long dbId, OlapTable table) {
Preconditions.checkState(table.isCloudNativeTableOrMaterializedView());
table.removeTableBinds(false);
RUNNING_DELETE_TABLE.computeIfAbsent(table, key -> new LakeTableCleaner(table, Lists.newArrayList()));
LakeTableCleaner cleaner = RUNNING_DELETE_TABLE.get(table);
// return false if submit failed or some of the deletion task has been failed.
boolean succ = cleaner.submitAndCheckAsyncCleanTable();
if (succ) {
table.removeTabletsFromInvertedIndex();
}
return succ;
}
| } | ||
| }); | ||
| return allSuccessed; | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
In the checkAllAsyncDeleteSuccessed method, clearing asyncDeleteReturn within the stream operation can cause a ConcurrentModificationException.
You can modify the code like this:
protected static boolean checkAllAsyncDeleteSuccessed(List<CompletableFuture<Boolean>> asyncDeleteReturn) {
boolean allSuccessed = false;
List<CompletableFuture<Boolean>> toBeRetried = new ArrayList<>();
allSuccessed = asyncDeleteReturn.stream().allMatch(future -> {
try {
return future != null && future.isDone() && future.get();
} catch (Exception e) {
// add to list for retrying later if any exception is thrown
toBeRetried.add(future);
return false;
}
});
asyncDeleteReturn.clear();
asyncDeleteReturn.addAll(toBeRetried);
return allSuccessed;
}
| } | ||
| } | ||
|
|
||
| return checkAllAsyncDeleteSuccessed(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential non-thread-safe access to asyncDeleteReturn
You can modify the code like this:
private final List<CompletableFuture<Boolean>> asyncDeleteReturn = Collections.synchronizedList(new ArrayList<>());
// And make sure other accesses to asyncDeleteReturn are synchronized properly.
// This method ensures thread-safe access when checking if all async deletions succeeded
private boolean checkAllAsyncDeleteSuccessed() {
synchronized (asyncDeleteReturn) {
return asyncDeleteReturn.stream().allMatch(future -> {
try {
return future != null && future.isDone() && future.get();
} catch (Exception e) {
// re-submit in the future if any exception is thrown
asyncDeleteReturn.clear();
return false;
}
});
}
}
srlch
force-pushed
the
enhance_remove_lock_recycle
branch
5 times, most recently
from
e07bb9f
to
01eef89
Compare
|
24 tasks
…ata mode Support Async delete files from Recycle Bin in shared data mode to avoid acquire lock for a long time. Signed-off-by: srlch <[email protected]>
srlch
force-pushed
the
enhance_remove_lock_recycle
branch
from
fadc804
to
00cfe0d
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 8 / 27 (29.63%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Async delete files from Recycle Bin in shared data mode to avoid acquire lock for a long time.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: