[BugFix] Fix null exception when insert overwrite job run concurrecy #50628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/persist/InsertOverwriteStateChangeInfo.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/load/InsertOverwriteJobRunner.java
Show resolved
Hide resolved
Signed-off-by: sevev <[email protected]>
gengjun-git
reviewed
Sep 5, 2024
fe/fe-core/src/main/java/com/starrocks/load/InsertOverwriteJobRunner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: sevev <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 29 / 34 (85.29%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
meegoo
reviewed
Sep 8, 2024
| List<String> sourcePartitionNames = job.getSourcePartitionIds().stream() | ||
| .map(partitionId -> targetTable.getPartition(partitionId).getName()) | ||
| .collect(Collectors.toList()); | ||
| List<String> sourcePartitionNames = job.getSourcePartitionNames(); |
There was a problem hiding this comment.
This will still lead to behavioral changes. Is there any intention in the original design? @Astralidea
There was a problem hiding this comment.
I'm not entirely sure, but I feel like it should be fine.
Astralidea
approved these changes
Sep 9, 2024
gengjun-git
approved these changes
Sep 12, 2024
wyb
approved these changes
Sep 12, 2024
| @@ -42,6 +42,9 @@ public class InsertOverwriteJob { | |||
| @SerializedName(value = "warehouseId") | |||
| private long warehouseId; | |||
|
|
|||
| @SerializedName(value = "sourcePartitionNames") | |||
| private List<String> sourcePartitionNames; | |||
There was a problem hiding this comment.
move to the back of sourcePartitionIds
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…50628) Signed-off-by: sevev <[email protected]> (cherry picked from commit 4b057ba)
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…50628) Signed-off-by: sevev <[email protected]> (cherry picked from commit 4b057ba) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/load/InsertOverwriteJob.java
Closed
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…50628) Signed-off-by: sevev <[email protected]> (cherry picked from commit 4b057ba) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/load/InsertOverwriteJob.java
Closed
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 18, 2024
…(backport #50628) (#50984) Co-authored-by: zhangqiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If we run multiple insert overwrite jobs concurrency with the same partition, we will first record the partition ids and replace partition at last. However, we will create a new partition with a new partition id and replace the old partition. So only the first insert overwrite job can run success because the following jobs can not find the partition according to the partition id and they will throw null exception.
What I'm doing:
Save the source partition name and try to find the partition according to the partition name.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: