[BugFix] add return type check in Java UDTF #50615

stdpain · 2024-09-03T03:44:40Z

Why I'm doing:

*** SIGSEGV (@0x228) received by PID 1463834 (TID 0x7f75201bc640) from PID 552; stack trace: ***
    @     0x7f767c211ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)
    @          0xc55e3a9 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f767cee101d os::Linux::chained_handler(int, siginfo_t*, void*)
    @     0x7f767cee5d49 JVM_handle_linux_signal
    @     0x7f767ced91f8 signalHandler(int, siginfo_t*, void*)
    @     0x7f767c1ba520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
    @     0x7f767ccb7924 jni_invoke_nonstatic(JNIEnv_*, JavaValue*, _jobject*, JNICallType, _jmethodID*, JNI_ArgumentPusher*, Thread*) [clone .constprop.233]
    @     0x7f767ccc1579 jni_CallLongMethodV
    @          0x56d9f6f JNIEnv_::CallLongMethod(_jobject*, _jmethodID*, ...)
    @          0x8a30313 starrocks::append_jvalue(starrocks::MethodTypeDescriptor, starrocks::Column*, jvalue)
    @          0x78c5cbd starrocks::JavaUDTFFunction::process(starrocks::RuntimeState*, starrocks::TableFunctionState*) const
    @          0x5b2514e starrocks::pipeline::TableFunctionOperator::_process_table_function(starrocks::RuntimeState*)
    @          0x5b266ea starrocks::pipeline::TableFunctionOperator::pull_chunk(starrocks::RuntimeState*)
    @          0x5abff76 starrocks::pipeline::PipelineDriver::process(starrocks::RuntimeState*, int)
    @          0x5aad0db starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
    @          0x8b62fd4 starrocks::ThreadPool::dispatch_thread()
    @          0x8b5c0f9 starrocks::Thread::supervise_thread(void*)
    @     0x7f767c20cac3 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x94ac2)
    @     0x7f767c29e850 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x12684f)

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: stdpain <[email protected]>

be/src/udf/java/java_data_converter.cpp

Signed-off-by: stdpain <[email protected]>

github-actions · 2024-09-03T13:07:56Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-03T13:08:00Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-03T13:17:55Z

[BE Incremental Coverage Report]

❌ fail : 36 / 55 (65.45%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/udf/java/java_data_converter.cpp	17	28	60.71%	[166, 167, 229, 246, 247, 248, 256, 257, 258, 259, 260]
🔵	be/src/udf/java/java_udf.h	5	8	62.50%	[122, 123, 124]
🔵	be/src/exprs/table_function/java_udtf_function.cpp	14	19	73.68%	[172, 173, 174, 175, 176]

github-actions · 2024-09-03T13:49:29Z

@Mergifyio backport branch-3.3

github-actions · 2024-09-03T13:49:31Z

@Mergifyio backport branch-3.2

github-actions · 2024-09-03T13:49:32Z

@Mergifyio backport branch-3.1

github-actions · 2024-09-03T13:49:34Z

@Mergifyio backport branch-3.0

mergify · 2024-09-03T13:49:52Z

backport branch-3.3

✅ Backports have been created

#50638 [BugFix] add return type check in Java UDTF (backport #50615) has been created for branch branch-3.3

mergify · 2024-09-03T13:49:53Z

backport branch-3.2

✅ Backports have been created

#50639 [BugFix] add return type check in Java UDTF (backport #50615) has been created for branch branch-3.2

mergify · 2024-09-03T13:49:55Z

backport branch-3.1

✅ Backports have been created

#50640 [BugFix] add return type check in Java UDTF (backport #50615) has been created for branch branch-3.1

mergify · 2024-09-03T13:49:56Z

backport branch-3.0

✅ Backports have been created

#50641 [BugFix] add return type check in Java UDTF (backport #50615) has been created for branch branch-3.0 but encountered conflicts

Signed-off-by: stdpain <[email protected]> (cherry picked from commit f147df2)

Signed-off-by: stdpain <[email protected]> (cherry picked from commit f147df2) # Conflicts: # test/sql/test_udf/R/test_jvm_udf # test/sql/test_udf/T/test_jvm_udf

Co-authored-by: stdpain <[email protected]>

StarRocks#50638) Co-authored-by: stdpain <[email protected]>

Signed-off-by: stdpain <[email protected]>

stdpain · 2024-09-18T02:47:36Z

https://github.com/Mergifyio backport branch-2.5

mergify · 2024-09-18T02:47:41Z

backport branch-2.5

✅ Backports have been created

#51082 [BugFix] add return type check in Java UDTF (backport #50615) has been created for branch branch-2.5 but encountered conflicts

Signed-off-by: stdpain <[email protected]> (cherry picked from commit f147df2) # Conflicts: # be/src/udf/java/java_data_converter.h # test/sql/test_udf/R/test_jvm_udf # test/sql/test_udf/T/test_jvm_udf

[BugFix] add return type check in UDTF

85a7d02

Signed-off-by: stdpain <[email protected]>

stdpain requested a review from a team as a code owner September 3, 2024 03:44

mergify bot assigned stdpain Sep 3, 2024

github-actions bot added 3.3 3.2 3.1 3.0 labels Sep 3, 2024

remove unused code equals

3c8e144

Signed-off-by: stdpain <[email protected]>

satanson previously approved these changes Sep 3, 2024

View reviewed changes

silverbullet233 reviewed Sep 3, 2024

View reviewed changes

be/src/udf/java/java_data_converter.cpp Outdated Show resolved Hide resolved

fix comments

381bdf3

Signed-off-by: stdpain <[email protected]>

stdpain dismissed satanson’s stale review via 381bdf3 September 3, 2024 11:42

silverbullet233 approved these changes Sep 3, 2024

View reviewed changes

kangkaisen merged commit f147df2 into StarRocks:main Sep 3, 2024
45 of 46 checks passed

github-actions bot removed the 3.3 label Sep 3, 2024

github-actions bot removed 3.2 3.1 labels Sep 3, 2024

github-actions bot removed the 3.0 label Sep 3, 2024

mergify bot pushed a commit that referenced this pull request Sep 3, 2024

[BugFix] add return type check in Java UDTF (#50615)

89a5ae0

Signed-off-by: stdpain <[email protected]> (cherry picked from commit f147df2)

mergify bot pushed a commit that referenced this pull request Sep 3, 2024

[BugFix] add return type check in Java UDTF (#50615)

6e33ad1

Signed-off-by: stdpain <[email protected]> (cherry picked from commit f147df2)

This was referenced Sep 3, 2024

[BugFix] add return type check in Java UDTF (backport #50615) #50638

Merged

[BugFix] add return type check in Java UDTF (backport #50615) #50639

Merged

mergify bot pushed a commit that referenced this pull request Sep 3, 2024

[BugFix] add return type check in Java UDTF (#50615)

b29abad

Signed-off-by: stdpain <[email protected]> (cherry picked from commit f147df2)

mergify bot mentioned this pull request Sep 3, 2024

[BugFix] add return type check in Java UDTF (backport #50615) #50640

Merged

42 tasks

mergify bot mentioned this pull request Sep 3, 2024

[BugFix] add return type check in Java UDTF (backport #50615) #50641

Closed

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Sep 4, 2024

[BugFix] add return type check in Java UDTF (backport #50615) (#50639)

b00dce5

Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.2-merged label Sep 4, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 4, 2024

[BugFix] add return type check in Java UDTF (backport #50615) (#50640)

7ebcc77

Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.1-merged label Sep 4, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 4, 2024

[BugFix] add return type check in Java UDTF (backport #50615) (#50638)

7103887

Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.3-merged label Sep 4, 2024

xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024

[BugFix] add return type check in Java UDTF (backport StarRocks#50615) (

71fbbcb

StarRocks#50638) Co-authored-by: stdpain <[email protected]>

va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024

[BugFix] add return type check in Java UDTF (StarRocks#50615)

19af27d

Signed-off-by: stdpain <[email protected]>

stdpain mentioned this pull request Sep 13, 2024

SR使用 UDTF 函数，创建成功，执行失败。异常： errorCode=2001 errorMessage:Channel inactive error!, host: unknown #50770

Closed

github-actions bot added 3.3 3.2 3.1 3.0 2.5 labels Sep 18, 2024

mergify bot mentioned this pull request Sep 18, 2024

[BugFix] add return type check in Java UDTF (backport #50615) #51082

Closed

42 tasks

stdpain mentioned this pull request Sep 20, 2024

[BugFix] Fix UDTF wrong result when miss multibyte UTF-8 #51232

Merged

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] add return type check in Java UDTF #50615

[BugFix] add return type check in Java UDTF #50615

stdpain commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

stdpain commented Sep 18, 2024

mergify bot commented Sep 18, 2024 •

edited

Loading

[BugFix] add return type check in Java UDTF #50615

[BugFix] add return type check in Java UDTF #50615

Conversation

stdpain commented Sep 3, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

github-actions bot commented Sep 3, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Sep 3, 2024

[FE Incremental Coverage Report]

github-actions bot commented Sep 3, 2024

[BE Incremental Coverage Report]

file detail

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

mergify bot commented Sep 3, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 3, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 3, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 3, 2024 • edited Loading

✅ Backports have been created

stdpain commented Sep 18, 2024

mergify bot commented Sep 18, 2024 • edited Loading

✅ Backports have been created

stdpain commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 18, 2024 •

edited

Loading